mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hare@suse.com,
	martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
	arnd@arndb.de, James Smart <jsmart2021@gmail.com>,
	James Smart <james.smart@broadcom.com>
Subject: [PATCH v2] scsi: lpfc: avoid false positive gcc-8 warning
Date: Wed, 23 Aug 2017 17:34:40 -0700	[thread overview]
Message-ID: <20170824003440.4270-1-jsmart2021@gmail.com> (raw)

Arnd Bergmann, testing gcc-8, encountered the following:

> This is an interesting regression with gcc-8, showing a harmless
> warning for correct code:
>
>In file included from include/linux/kernel.h:13:0,
>    ...
>    from drivers/scsi/lpfc/lpfc_debugfs.c:23:
>    include/linux/printk.h:301:2: error: 'eq' may be used
>    uninitialized in this function [-Werror=maybe-uninitialized]
>       printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>       ^~~~~~
>    In file included from drivers/scsi/lpfc/lpfc_debugfs.c:58:0:
>    drivers/scsi/lpfc/lpfc_debugfs.h:451:31: note: 'eq' was
>    declared here

The code is fine: a for loop which if there's at least 1 itteration,
will assign eq a value. Followed by an if test that checks for no
itterations and assigns eq a default value. But the checker doesn't
see the relationship between the two so assumes eq may not a have a
value.

I believe, simply initializing with a NULL will solve the issue.

Signed-off-by: James Smart <james.smart@broadcom.com>
---
 drivers/scsi/lpfc/lpfc_debugfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_debugfs.h b/drivers/scsi/lpfc/lpfc_debugfs.h
index 7b7d314af0e0..32e86d7813a0 100644
--- a/drivers/scsi/lpfc/lpfc_debugfs.h
+++ b/drivers/scsi/lpfc/lpfc_debugfs.h
@@ -448,7 +448,7 @@ lpfc_debug_dump_wq(struct lpfc_hba *phba, int qtype, int wqidx)
 static inline void
 lpfc_debug_dump_cq(struct lpfc_hba *phba, int qtype, int wqidx)
 {
-	struct lpfc_queue *wq, *cq, *eq;
+	struct lpfc_queue *wq, *cq, *eq = NULL;
 	char *qtypestr;
 	int eqidx;
 
-- 
2.13.1

             reply	other threads:[~2017-08-24  0:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24  0:34 James Smart [this message]
2017-08-24 11:01 ` Arnd Bergmann
2017-08-24 16:28   ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824003440.4270-1-jsmart2021@gmail.com \
    --to=jsmart2021@gmail.com \
    --cc=arnd@arndb.de \
    --cc=hare@suse.com \
    --cc=james.smart@broadcom.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®