From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751128AbdHXAkt (ORCPT ); Wed, 23 Aug 2017 20:40:49 -0400 Received: from mail-pg0-f46.google.com ([74.125.83.46]:36714 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbdHXAkr (ORCPT ); Wed, 23 Aug 2017 20:40:47 -0400 Date: Thu, 24 Aug 2017 09:41:03 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Helge Deller , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org Subject: Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF Message-ID: <20170824004103.GA3569@jagdpanzerIV.localdomain> References: <20170810173533.GA11600@ls3530.fritz.box> <20170811001521.GA520@jagdpanzerIV.localdomain> <47718712-9eb2-8ad7-965e-d0971d07e985@gmx.de> <20170815113625.GA2738@pathway.suse.cz> <20170823144824.GE27895@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170823144824.GE27895@pathway.suse.cz> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (08/23/17 16:48), Petr Mladek wrote: [..] > Sometimes people seems unclear when to use the %pS or %pF printk format. > For example, see commit 51d96dc2e2dc ("random: fix warning message on ia64 > and parisc") which fixed such a wrong format string. > > The documentation should be more clear about the difference. > Also examples might help to avoid some typical mistakes. > > Signed-off-by: Helge Deller > [pmladek@suse.com: Restructure the entire section] > Signed-off-by: Petr Mladek looks great. FWIW, Reviewed-by: Sergey Senozhatsky -ss