From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751778AbdHXJVR (ORCPT ); Thu, 24 Aug 2017 05:21:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:53845 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751259AbdHXJVQ (ORCPT ); Thu, 24 Aug 2017 05:21:16 -0400 Date: Thu, 24 Aug 2017 11:21:13 +0200 From: Petr Mladek To: Helge Deller Cc: Steven Rostedt , Sergey Senozhatsky , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org Subject: Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF Message-ID: <20170824092113.GE30286@pathway.suse.cz> References: <20170810173533.GA11600@ls3530.fritz.box> <20170811001521.GA520@jagdpanzerIV.localdomain> <47718712-9eb2-8ad7-965e-d0971d07e985@gmx.de> <20170815113625.GA2738@pathway.suse.cz> <20170823144824.GE27895@pathway.suse.cz> <20170823104947.3d84737e@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2017-08-23 21:36:21, Helge Deller wrote: > On 23.08.2017 16:49, Steven Rostedt wrote: > > On Wed, 23 Aug 2017 16:48:24 +0200 > > Petr Mladek wrote: > > > >> + > >> + printk("Going to call: %pF\n", gettimeofday); > >> + printk("Going to call: %pF\n", p->func); > >> + printk("%s: called from %pS\n", __func__, _RET_IP_); > >> + printk("%s: called from %pS\n", __func__, __builtin_return_address(0)); > >> + printk("Faulted at %pS\n", (void *)regs->ip); > >> + printk(" %s%pB\n", reliable ? "" : "? ", (void *)*stack); > > > > Much better! > > Petr, that's really much better. > > I've already pushed the part which restructured the text upstream. Ah, great, I have missed this. > I'll push this part of the patch (which adds the examples) for v4.14. Sounds good. Thanks, Petr