mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liviu Dudau <liviu.dudau@arm.com>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, sudeep.holla@arm.com,
	lorenzo.pieralisi@arm.com, mturquette@baylibre.com,
	sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: versatile: make clk_ops const
Date: Thu, 24 Aug 2017 10:54:42 +0100	[thread overview]
Message-ID: <20170824095442.GC11316@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <1503410786-25519-1-git-send-email-bhumirks@gmail.com>

On Tue, Aug 22, 2017 at 07:36:26PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the const field of a
> clk_init_data structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>

Thanks for the patch!

Sudeep, can you going to pick this up for 4.14?

Best regards,
Liviu

> ---
>  drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c
> index 7e5add7..e7a868b 100644
> --- a/drivers/clk/versatile/clk-vexpress-osc.c
> +++ b/drivers/clk/versatile/clk-vexpress-osc.c
> @@ -61,7 +61,7 @@ static int vexpress_osc_set_rate(struct clk_hw *hw, unsigned long rate,
>  	return regmap_write(osc->reg, 0, rate);
>  }
>  
> -static struct clk_ops vexpress_osc_ops = {
> +static const struct clk_ops vexpress_osc_ops = {
>  	.recalc_rate = vexpress_osc_recalc_rate,
>  	.round_rate = vexpress_osc_round_rate,
>  	.set_rate = vexpress_osc_set_rate,
> -- 
> 1.9.1
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

  reply	other threads:[~2017-08-24  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 14:06 Bhumika Goyal
2017-08-24  9:54 ` Liviu Dudau [this message]
2017-08-24 10:20   ` Sudeep Holla
2017-08-31  5:39 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824095442.GC11316@e110455-lin.cambridge.arm.com \
    --to=liviu.dudau@arm.com \
    --cc=bhumirks@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®