From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753265AbdHXNzS (ORCPT ); Thu, 24 Aug 2017 09:55:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:60852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdHXNzR (ORCPT ); Thu, 24 Aug 2017 09:55:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2969D21A29 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 24 Aug 2017 09:55:14 -0400 From: Steven Rostedt To: Byungchul Park Cc: peterz@infradead.org, mingo@kernel.org, joel.opensrc@gmail.com, linux-kernel@vger.kernel.org, juri.lelli@gmail.com, kernel-team@lge.com Subject: Re: [PATCH v10 2/2] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq() Message-ID: <20170824095514.48222762@gandalf.local.home> In-Reply-To: <1503536763-14912-3-git-send-email-byungchul.park@lge.com> References: <1503536763-14912-1-git-send-email-byungchul.park@lge.com> <1503536763-14912-3-git-send-email-byungchul.park@lge.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Aug 2017 10:06:03 +0900 Byungchul Park wrote: > Hello Steven, > > Can I keep your reviewed-by with comments modified? Yes, but I have one nit. > @@ -1668,9 +1691,35 @@ static int find_lowest_rq(struct task_struct *task) > return this_cpu; > } > > - best_cpu = cpumask_first_and(lowest_mask, > - sched_domain_span(sd)); > + /* > + * If a cpu being in lowest_mask & current sd & > + * ~prefer sd is valid, that becomes our choice. I can't parse the above sentence. -- Steve > + * Of course, the lowest possible cpu is already > + * under consideration through lowest_mask. > + */ > + best_cpu = find_cpu(lowest_mask, sd, prefer); > +