From: Dan Carpenter <dan.carpenter@oracle.com>
To: Baoquan He <bhe@redhat.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
joro@8bytes.org
Subject: Re: [PATCH] iommu/amd: Check if domain is NULL before dereference it
Date: Thu, 24 Aug 2017 15:32:26 +0300 [thread overview]
Message-ID: <20170824123226.57twp5sdh246l5kz@mwanda> (raw)
In-Reply-To: <20170824122251.GG19768@x1>
Take a look at this code for example. But all the places which call
get_domain() are the same:
drivers/iommu/amd_iommu.c
2648 page = virt_to_page(virt_addr);
2649 size = PAGE_ALIGN(size);
2650
2651 domain = get_domain(dev);
^^^^^^^^^^^^^^
imagined get_domain() returns NULL.
2652 if (IS_ERR(domain))
2653 goto free_mem;
2654
2655 dma_dom = to_dma_ops_domain(domain);
^^^^^^^^^^^^^^^^^^^^^^^^^
This will Oops.
2656
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-24 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 11:56 Baoquan He
2017-08-24 12:11 ` Dan Carpenter
2017-08-24 12:22 ` Baoquan He
2017-08-24 12:32 ` Dan Carpenter [this message]
2017-08-24 12:47 ` Baoquan He
2017-08-24 12:53 ` Dan Carpenter
2017-08-24 13:01 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824123226.57twp5sdh246l5kz@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bhe@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®