From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753058AbdHXOId (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 10:08:33 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:43208 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752994AbdHXOIb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 10:08:31 -0400
Date: Thu, 24 Aug 2017 17:07:37 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Shurong Zhang <zhang_shurong@foxmail.com>
Cc: Jens Frederich <jfrederich@gmail.com>, Daniel Drake <dsd@laptop.org>,
        Jon Nettleton <jon.nettleton@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel <devel@driverdev.osuosl.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: olpc_dcon: remove pointless debug printk in
 dcon_freeze_store()
Message-ID: <20170824140737.ke2ebr5u73jrm7qq@mwanda>
References: <599e6e01.c9d9540a.b4229.15c6SMTPIN_ADDED_BROKEN@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <599e6e01.c9d9540a.b4229.15c6SMTPIN_ADDED_BROKEN@mx.google.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 24, 2017 at 02:10:37PM +0800, Shurong Zhang wrote:
> This printk doesn't really add anything worthwhile.
> 
> Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..f9d9465 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,6 @@ static ssize_t dcon_freeze_store(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	pr_info("dcon_freeze_store: %lu\n", output);
>  

Delete a blank line as well.  We don't allow two blank lines in a row.

regards,
dan carpenter