From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Michal Hocko <mhocko@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: arch/arm/kernel/setup.c fails to compile for NOMMU
Date: Thu, 24 Aug 2017 17:17:41 +0100 [thread overview]
Message-ID: <20170824161741.GX20805@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170818112402.GB18499@dhcp22.suse.cz>
On Fri, Aug 18, 2017 at 01:24:02PM +0200, Michal Hocko wrote:
> Hi Russel,
> I have a battery of configs for compile testing and for some time I've
> been seeing the following compilation error with nommu config (attached)
>
> arch/arm/kernel/setup.c: In function 'reserve_crashkernel':
> arch/arm/kernel/setup.c:1005:25: error: 'SECTION_SIZE' undeclared (first
> use in this function)
> crash_size, SECTION_SIZE);
>
> I didn't get to look what is going on here, maybe my config is just too
> artificial but the primary reason is that SECTION_SIZE is not defined in
> pgtable-nommu.h. To be honest I am not familiar with nommu very much and
> it smells like the whole reserve_crashkernel doesn't really make any
> sense on those configs. Could you have a look what is the best fix
> please?
Hi,
I suspect that mach-netx has never been tested in nommu configurations
(ditto for many of the older platforms, which pre-date merging nommu
support.)
Maybe the best solution is to make these old platforms depend on MMU.
However, I'm wondering whether kexec makes sense for !MMU - that's
probably something that hasn't been tested and doesn't actually work.
So maybe another approach would be to make kexec depend on MMU for
ARM - but I'm afraid I don't really know.
I only have very limited nommu experience.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-08-24 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 11:24 Michal Hocko
2017-08-24 16:17 ` Russell King - ARM Linux [this message]
2017-08-25 6:45 ` Michal Hocko
2018-04-06 9:56 ` Michal Hocko
2019-03-05 22:08 ` Stefan Agner
2019-03-11 8:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824161741.GX20805@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®