From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754171AbdHXXNI (ORCPT ); Thu, 24 Aug 2017 19:13:08 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:55651 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753702AbdHXXNH (ORCPT ); Thu, 24 Aug 2017 19:13:07 -0400 From: Arnd Bergmann To: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , Hannes Reinecke , Johannes Thumshirn , Dan Carpenter , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] scsi: lpfc: avoid an unused function warning Date: Fri, 25 Aug 2017 01:09:59 +0200 Message-Id: <20170824231016.1843118-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:985d7LTdqjYRheLG9Y7PCkjRHpqHlIneRgAif3Tm2FaTAEpVjvW 2z7djQiD6YDpp3dXAPjQaPjYWtombpIlfULvDOzw/yttjVxTO2nIv5drXiHlIqzDwJX6tu2 9juk7He3aCN2jQPfNHEesgzfEZjSMQ67i5TvqHGE78GBZblMFzMEw0/SfGzFroDamSg3RAl LPF0nb8A1AzxXCTFYqbKw== X-UI-Out-Filterresults: notjunk:1;V01:K0:g/dtvsbj+Jw=:/vD1gI1pcbYzIch9+ZoPS/ ECPDSEGBpEIchFKFT+RES95OqQc7BBGr0rzzqrnqNUFLzbqv5y3i2gT6g/qcqF+DX4KorJzBa 1hbAs4oScyj7waAT0772++au9QQ47j6zQuKhGvxBU/AUTKm0A3TUzXG+T8J/w8sOTqSLmeyr0 FbQt1a+dEcCtQTBDmboaThJXYLihnvDEdOgyO5rjattJ8OnkyYn3DjbsLz6aatuDSQgkYTz7U txBP1WbtC77MtI9xfJ91vQcETXrHKcvx4O7wRzSnJ1cl/lqaSRk34uORqvImPtz5aILMvVtLM 0yn78V6OpHlvb2h+ydxO9X55oeTiR1/5ztzy2yOi9f0Rxn60+9IZB2OimMK79VoGkU2co+WyG hWkyXK1Wuc9AOYKrEm0OrGKiOj41qiXral3GXCgImM3EVQgqzzklf1fxkZORmWNjO3xEmgIrr u/HUhSkGnYBXmY7CLpFPTuu8hmU5rUdTzcxzGz+rlmEWi5iLiUsBQygFUDPxgPFG723BWCqei sOOf2/JrHnNSkKshz+j6FiE4PP45h00eDz1UNzScolHJW47AvzOns1aPEspKkZTJT56q33RBb VJ5lOnHEghFUrzLf/yt39Ay/N/qLW0HUvc5Rjug1ycoOm+YKhnPMJBeg8mA/hQGdGUa7FMoBP dwhkqss8a/FLAmYcYIKA7TObgFRTjIfRKGl1QaeDk9Fp9jRk0eH60UzsP1lM3NSYP0F1Kq7ch KpDmtzl2yXV02FAHMCDPgqKf6adHiAuWaCOVJw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The only reference to lpfc_nvmet_replenish_context() is inside of an #ifdef, leading to a harmless warning when CONFIG_NVME_TARGET_FC is disabled: drivers/scsi/lpfc/lpfc_nvmet.c:1457:1: error: 'lpfc_nvmet_replenish_context' defined but not used [-Werror=unused-function] This replaces the preprocessor conditional with a C condition, so the compiler can see that the function is intentionally unused. Fixes: 9a38e4f1c82f ("scsi: lpfc: Fix MRQ > 1 context list handling") Signed-off-by: Arnd Bergmann --- drivers/scsi/lpfc/lpfc_nvmet.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c index 48a1c0c27a3f..0b7c1a49e203 100644 --- a/drivers/scsi/lpfc/lpfc_nvmet.c +++ b/drivers/scsi/lpfc/lpfc_nvmet.c @@ -1527,7 +1527,6 @@ lpfc_nvmet_unsol_fcp_buffer(struct lpfc_hba *phba, struct rqb_dmabuf *nvmebuf, uint64_t isr_timestamp) { -#if (IS_ENABLED(CONFIG_NVME_TARGET_FC)) struct lpfc_nvmet_rcv_ctx *ctxp; struct lpfc_nvmet_tgtport *tgtp; struct fc_frame_header *fc_hdr; @@ -1541,6 +1540,9 @@ lpfc_nvmet_unsol_fcp_buffer(struct lpfc_hba *phba, uint32_t id; #endif + if (!IS_ENABLED(CONFIG_NVME_TARGET_FC)) + return; + ctx_buf = NULL; if (!nvmebuf || !phba->targetport) { lpfc_printf_log(phba, KERN_ERR, LOG_NVME_IOERR, @@ -1695,7 +1697,6 @@ lpfc_nvmet_unsol_fcp_buffer(struct lpfc_hba *phba, if (nvmebuf) lpfc_rq_buf_free(phba, &nvmebuf->hbuf); /* repost */ -#endif } /** -- 2.9.0