From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754251AbdHYBbG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 21:31:06 -0400
Received: from LGEAMRELO12.lge.com ([156.147.23.52]:57286 "EHLO
        lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753456AbdHYBbF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 21:31:05 -0400
X-Original-SENDERIP: 156.147.1.126
X-Original-MAILFROM: byungchul.park@lge.com
X-Original-SENDERIP: 10.177.222.33
X-Original-MAILFROM: byungchul.park@lge.com
Date: Fri, 25 Aug 2017 10:31:00 +0900
From: Byungchul Park <byungchul.park@lge.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: peterz@infradead.org, mingo@kernel.org, joel.opensrc@gmail.com,
        linux-kernel@vger.kernel.org, juri.lelli@gmail.com,
        kernel-team@lge.com
Subject: Re: [PATCH v10 2/2] sched/rt: Add support for SD_PREFER_SIBLING on
 find_lowest_rq()
Message-ID: <20170825013100.GC3858@X58A-UD3R>
References: <1503536763-14912-1-git-send-email-byungchul.park@lge.com>
 <1503536763-14912-3-git-send-email-byungchul.park@lge.com>
 <20170824095514.48222762@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170824095514.48222762@gandalf.local.home>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 24, 2017 at 09:55:14AM -0400, Steven Rostedt wrote:
> On Thu, 24 Aug 2017 10:06:03 +0900
> Byungchul Park <byungchul.park@lge.com> wrote:
> 
> > Hello Steven,
> > 
> > Can I keep your reviewed-by with comments modified?
> 
> Yes, but I have one nit.
> 
> 
> > @@ -1668,9 +1691,35 @@ static int find_lowest_rq(struct task_struct *task)
> >  				return this_cpu;
> >  			}
> >  
> > -			best_cpu = cpumask_first_and(lowest_mask,
> > -						     sched_domain_span(sd));
> > +			/*
> > +			 * If a cpu being in lowest_mask & current sd &
> > +			 * ~prefer sd is valid, that becomes our choice.
> 
> I can't parse the above sentence.

I might have simplified the comment too much.

~prefer means we want to exclude the domain span having SD_PREFER_SIBLING,
since they should be considered as fallback candidates.

W/o ~prefer, a cpu in the domain might be chosen when we consider higher
domain than the domain having SD_PREFER_SIBLING, as the best cpu, not
fallback.