From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
David Daney <david.daney@cavium.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH v2] irqdomain: potential Oops in irq_domain_push_irq()
Date: Fri, 25 Aug 2017 12:10:00 +0300 [thread overview]
Message-ID: <20170825091000.z5taav6xj2yds6ch@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.20.1708251042500.1883@nanos>
This code generates a Smatch warning:
kernel/irq/irqdomain.c:1511 irq_domain_push_irq()
warn: variable dereferenced before check 'root_irq_data' (see line 1508)
irq_get_irq_data() does sometimes return NULL pointers so it does look
like this code could Oops. I've moved the check for NULL earlier to
fix this bug.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: redo the commit message
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index b9c688944429..e84b7056bb08 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -1505,10 +1505,10 @@ int irq_domain_push_irq(struct irq_domain *domain, int virq, void *arg)
if (WARN_ON(!irq_domain_is_hierarchy(domain)))
return -EINVAL;
- if (domain->parent != root_irq_data->domain)
+ if (!root_irq_data)
return -EINVAL;
- if (!root_irq_data)
+ if (domain->parent != root_irq_data->domain)
return -EINVAL;
child_irq_data = kzalloc_node(sizeof(*child_irq_data), GFP_KERNEL,
next prev parent reply other threads:[~2017-08-25 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 7:13 [PATCH] irqdomain: check for NULL before dereferencing Dan Carpenter
2017-08-25 8:45 ` Thomas Gleixner
2017-08-25 9:10 ` Dan Carpenter [this message]
2017-08-25 11:08 ` [PATCH v2] irqdomain: potential Oops in irq_domain_push_irq() Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825091000.z5taav6xj2yds6ch@mwanda \
--to=dan.carpenter@oracle.com \
--cc=david.daney@cavium.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®