From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933430AbdHYO6V (ORCPT <rfc822;w@1wt.eu>);
        Fri, 25 Aug 2017 10:58:21 -0400
Received: from mail.kernel.org ([198.145.29.99]:59860 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932732AbdHYO6T (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Aug 2017 10:58:19 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77443219AA
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Fri, 25 Aug 2017 10:58:14 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: John Stultz <john.stultz@linaro.org>,
        Joel Fernandes <joelaf@google.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Mark Salyzyn <salyzyn@android.com>, Jonathan Corbet <corbet@lwn.net>,
        Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Christoffer Dall <cdall@linaro.org>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Nicholas Piggin <npiggin@gmail.com>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Olof Johansson <olof@lixom.net>, Josh Poimboeuf <jpoimboe@redhat.com>,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2 v8] printk: Add monotonic, boottime, and realtime
 timestamps
Message-ID: <20170825105814.3cf3ff50@gandalf.local.home>
In-Reply-To: <dac013d8-e70d-a89a-b2fb-d7651df983b0@redhat.com>
References: <1503582122-22841-1-git-send-email-prarit@redhat.com>
        <1503582122-22841-3-git-send-email-prarit@redhat.com>
        <CALAqxLUd4nEiayhEMCRCmDm4NrU+4T_VkmafRxJepbGQUg-iEQ@mail.gmail.com>
        <dac013d8-e70d-a89a-b2fb-d7651df983b0@redhat.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 25 Aug 2017 10:46:21 -0400
Prarit Bhargava <prarit@redhat.com> wrote:


> np.  I'm going to copy the code for
> 
> u64 notrace ktime_get_boot_fast_ns(void)
> 
> but I'm unsure why the function is marked "notrace", and if
> __ktime_get_real_fast_ns_unsafe() must be as well?  I don't see anything in the
> git log that indicates why the function is notrace.
> 
> I've added Joel to this thread ...

The "notrace" is added because it is one of the trace clocks:

kernel/trace/trace.c:   { ktime_get_boot_fast_ns,       "boot",         1 },

And function tracer can use it. We don't want to be tracing the clock
that the function tracer is using (otherwise it will get double
traced). It use to bug, but I believe I finally got the recursion
protection working to prevent that.

-- Steve