From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933884AbdHYPtv (ORCPT ); Fri, 25 Aug 2017 11:49:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:37308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933662AbdHYPtu (ORCPT ); Fri, 25 Aug 2017 11:49:50 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CDEC219AA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 25 Aug 2017 11:49:47 -0400 From: Steven Rostedt To: Thomas Gleixner Cc: LKML , Ingo Molnar , Peter Anvin , Peter Zijlstra , Andy Lutomirski , Borislav Petkov Subject: Re: [patch 10/41] x86/apic: Remove the duplicated tracing versions of interrupts Message-ID: <20170825114947.6827e8c5@gandalf.local.home> In-Reply-To: <20170825104413.763114746@linutronix.de> References: <20170825103103.287814238@linutronix.de> <20170825104413.763114746@linutronix.de> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Aug 2017 12:31:13 +0200 Thomas Gleixner wrote: > The error and the spurious interrupt are really rare events and not at all > so performance sensitive that two NOP5s can not be tolerated when tracing > is disabled. Just a note. I'm sure if we disassembled it, it may be a little more work done than just two NOPs, as parameter passing to the tracepoints sometimes leak out of the static jump block. It's moot on this patch, but other irqs with fast paths may need to be looked at. > > Remove the nonsense. > > Signed-off-by: Thomas Gleixner > --- > arch/x86/include/asm/hw_irq.h | 4 +-- > arch/x86/kernel/apic/apic.c | 43 +++++++++--------------------------------- > 2 files changed, 12 insertions(+), 35 deletions(-) > Reviewed-by: Steven Rostedt (VMware) -- Steve