From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751392AbdH0QpT (ORCPT ); Sun, 27 Aug 2017 12:45:19 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:52517 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751273AbdH0QpQ (ORCPT ); Sun, 27 Aug 2017 12:45:16 -0400 Date: Sun, 27 Aug 2017 09:45:14 -0700 From: Guenter Roeck To: Colin King Cc: Greg Kroah-Hartman , Badhri Jagan Sridharan , Thomas Gardner , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][staging-next] staging: typec: tcpm: make function tcpm_get_pwr_opmode Message-ID: <20170827164514.GC22819@roeck-us.net> References: <20170822160218.32316-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170822160218.32316-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2017 at 05:02:18PM +0100, Colin King wrote: > From: Colin Ian King > > The function pointer tcpm_get_pwr_opmode is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'tcpm_get_pwr_opmode' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c > index 7b5ba27dd935..a911cad41a59 100644 > --- a/drivers/staging/typec/tcpm.c > +++ b/drivers/staging/typec/tcpm.c > @@ -2131,7 +2131,7 @@ static void tcpm_swap_complete(struct tcpm_port *port, int result) > } > } > > -enum typec_pwr_opmode tcpm_get_pwr_opmode(enum typec_cc_status cc) > +static enum typec_pwr_opmode tcpm_get_pwr_opmode(enum typec_cc_status cc) > { > switch (cc) { > case TYPEC_CC_RP_1_5: > -- > 2.14.1 >