From: Dan Carpenter <dan.carpenter@oracle.com>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
insafonov@gmail.com, linux-kernel@vger.kernel.org,
hdegoede@redhat.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8723bs: remove memset before memcpy
Date: Mon, 28 Aug 2017 09:19:06 +0300 [thread overview]
Message-ID: <20170828061231.yalsogu62qskhter@mwanda> (raw)
In-Reply-To: <1503864811-8226-1-git-send-email-himanshujha199640@gmail.com>
On Mon, Aug 28, 2017 at 01:43:31AM +0530, Himanshu Jha wrote:
> calling memcpy immediately after memset with the same region of memory
> makes memset redundant.
>
> Build successfully.
>
Thanks for the patch, it looks good. You don't need to say that it
builds successfully, because we already assume that's true.
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
Sometimes I put a comment here under the cut off line if I want people
to know that I haven't tested a patch.
Anyway, don't resend the patch. It's fine as-is (unless Greg
complains) but it's just for future reference.
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-28 6:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 20:13 Himanshu Jha
2017-08-28 6:19 ` Dan Carpenter [this message]
2017-08-28 7:18 ` Himanshu Jha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828061231.yalsogu62qskhter@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=himanshujha199640@gmail.com \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®