From: Steven Rostedt <rostedt@goodmis.org>
To: Zhou Chengming <zhouchengming1@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <mingo@redhat.com>
Subject: Re: [PATCH] tracing: make dynamic types can use __TRACE_LAST_TYPE
Date: Mon, 28 Aug 2017 07:01:46 -0400 [thread overview]
Message-ID: <20170828070146.16d65ca0@gandalf.local.home> (raw)
In-Reply-To: <1503896348-134351-1-git-send-email-zhouchengming1@huawei.com>
On Mon, 28 Aug 2017 12:59:08 +0800
Zhou Chengming <zhouchengming1@huawei.com> wrote:
> Obviously, trace_events that defined staticly in trace.h won't use
> __TRACE_LAST_TYPE, so make dynamic types can use it. And some
> minor changes to trace_search_list() to make code clearer.
Is there some reason to do this? I'm not sure it makes the code any
clearer. It looks like churn for churn sake. Which means that it can
cause a bug, and requires a bit of work to verify it does not.
Now if there's other work that is being done that requires this change,
then I have no problem adding it. But if it is just to "make it
clearer" then no, I'm not adding it.
-- Steve
>
> Signed-off-by: Zhou Chengming <zhouchengming1@huawei.com>
prev parent reply other threads:[~2017-08-28 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 4:59 Zhou Chengming
2017-08-28 11:01 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828070146.16d65ca0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®