From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751639AbdH1KCF (ORCPT ); Mon, 28 Aug 2017 06:02:05 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:49803 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbdH1KBH (ORCPT ); Mon, 28 Aug 2017 06:01:07 -0400 X-AuditID: b6c32a47-f79db6d000003732-3c-59a3e9e1fa6e From: Jaechul Lee To: Krzysztof Kozlowski , Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, galaxyra@gmail.com, Jaechul Lee , Chanwoo Choi Subject: [PATCH 3/3] ASoC: samsung: Fix invalid argument when devm_gpiod_get is called Date: Mon, 28 Aug 2017 19:01:02 +0900 Message-id: <20170828100102.17591-4-jcsing.lee@samsung.com> X-Mailer: git-send-email 2.14.1 In-reply-to: <20170828100102.17591-1-jcsing.lee@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHKsWRmVeSWpSXmKPExsWy7bCmme7Dl4sjDTpPGVtcuXiIyWLqwyds Fte/PGe1OL5yFrPF2/3dzBbnz29gt/h2pYPJ4vKuOWwWM87vY7Lo3NXPanH4TTurxcUVX5gs Nnxfy+jA67HhcxObx85Zd9k9Nq3qZPPY93YZm0ffllWMHuu3XGXx+LxJLoA9KtUmIzUxJbVI ITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+hcJYWyxJxSoFBAYnGx kr6dTVF+aUmqQkZ+cYmtUrShoZGeoYG5npGRkZ6JcayVkSlQSUJqxps9Z5gKPnBW3L57kq2B cS1HFyMnh4SAicShY/dZIWwxiQv31rOB2EICOxgl3vzP6GLkArK/M0q0bP3EDtNwo7GZBaJo N6PE9yVKcEUXu3sZQRJsAloS/Ut62EASIgLLmCT27DrNCOIwCywHqnq9gBmkSlggQuLZjXNg NouAqsSfs7/AVvAKWEusbfjBCLFOXuLcg9tgNZwCNhILNz1hBxkkIXCCTWLq7CtsEEUuEo3/ DkE9ISzx6vgWqFulJZ6t2sgI0dDOKHHo5lcop4NRYt+VBVDdxhKnuhqZQGxmAT6JjsN/gbo5 gOK8Eh1tQhAlHhITzn1mgbAdJVp2fGKCBEA/o8Tpv1ITGKUXMDKsYhRLLSjOTU8tNiow1itO zC0uzUvXS87P3cQITlta7jsYt53zOcQowMGoxMN7QntxpBBrYllxZe4hRgkOZiUR3kpg0hPi TUmsrEotyo8vKs1JLT7EaAoMnInMUqLJ+cCUmlcSb2hiaWBiZmZkbmYBTBvivHXbrkUICaQn lqRmp6YWpBbB9DFxcEo1ME5KZ89+2Se30u7y5My1u6/VFC303mP6yeQt441bnKd37mm9dkRH RHMZw3Xhmdt3LbtR1uL/lyWr8e1yUf68iLl/6+2vKF1pu2uiM1VyzdWHVxOuVGyzFZ5g5CTU 4FDUfOPB8Q7DSPEz8w7KSYhVe+tad09+dMVx6+T3Rnb8Gy3VeXce2fnrRZESS3FGoqEWc1Fx IgCu604FcQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCLMWRmVeSWpSXmKPExsVy+t9jAd2HLxdHGvzYr2Zx5eIhJoupD5+w WVz/8pzV4vjKWcwWb/d3M1ucP7+B3eLblQ4mi8u75rBZzDi/j8mic1c/q8XhN+2sFhdXfGGy 2PB9LaMDr8eGz01sHjtn3WX32LSqk81j39tlbB59W1YxeqzfcpXF4/MmuQD2KC6blNSczLLU In27BK6MN3vOMBV84Ky4ffckWwPjWo4uRk4OCQETiRuNzSxdjFwcQgI7GSVaLm2Ccr4zSnxY e5EFpIpNQEuif0kPG4gtIrCMSeL7xxyQImaB5YwSj44sZO1i5OAQFoiQOHoIrJ5FQFXiz9lf 7CA2r4C1xNqGH4wQ2+Qlzj24zQxicwrYSCzc9ASsRgioZvO1FewTGHkWMDKsYpRMLSjOTc8t Niowykst1ytOzC0uzUvXS87P3cQIDMtth7X6dzA+XhJ/iFGAg1GJh7fDbnGkEGtiWXFl7iFG CQ5mJRHe10+AQrwpiZVVqUX58UWlOanFhxilOViUxHkz+2ZECgmkJ5akZqemFqQWwWSZODil Ghh3RF7bcnkPT3WH6BrHs/92pux7w3crNv+ngaF1lMUB3rvuLCf0tdrl2iWF9Nq+/uj/cLKJ wWT+8z/X4qV+OybGZ/sxSXRVJi3YOHnxEiWhDPmAf+vFohONHu6P3V2vs/3x8YC62ht/dium rOIRLudrCjzK/5L5nbCv/o9XQvq9Alc9J8cz/FNiKc5INNRiLipOBADeRpPoRwIAAA== X-CMS-MailID: 20170828100105epcas2p3b528f17ba89532835e9b1735a0016215 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?7J207J6s7LKgG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SmFlQ2h1bCBMZWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170828100105epcas2p3b528f17ba89532835e9b1735a0016215 X-RootMTR: 20170828100105epcas2p3b528f17ba89532835e9b1735a0016215 References: <20170828100102.17591-1-jcsing.lee@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_gpiod_get is called with GPIOF_OUT_INIT_LOW but the function doesn't allow the parameters. Unluckily, GPIOF_OUT_INIT_LOW is same value as GPIOD_IN so it works like input gpio. Muted stream comes up when I try recording some sounds on TM2. mic-bias gpiod state can't be changed because the gpiod is created with the invalid parameter. The gpio should be set GPIOD_OUT_HIGH. Fixes: 1bfbc260a5b4 ("ASoC: samsung: Add machine driver for Exynos5433 based TM2 board") Signed-off-by: Jaechul Lee --- sound/soc/samsung/tm2_wm5110.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c index f467ad06e827..76abe45ed537 100644 --- a/sound/soc/samsung/tm2_wm5110.c +++ b/sound/soc/samsung/tm2_wm5110.c @@ -439,8 +439,7 @@ static int tm2_probe(struct platform_device *pdev) snd_soc_card_set_drvdata(card, priv); card->dev = dev; - priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias", - GPIOF_OUT_INIT_LOW); + priv->gpio_mic_bias = devm_gpiod_get(dev, "mic-bias", GPIOD_OUT_HIGH); if (IS_ERR(priv->gpio_mic_bias)) { dev_err(dev, "Failed to get mic bias gpio\n"); return PTR_ERR(priv->gpio_mic_bias); -- 2.14.1