From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "Alessandro Zummo" <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Roc He" <hepeng@zidoo.tv>,
蒋丽琴 <jiang.liqin@geniatech.com>
Subject: Re: [PATCH v3 2/3] rtc: Add Realtek RTD1295
Date: Mon, 28 Aug 2017 18:16:27 +0200 [thread overview]
Message-ID: <20170828161627.4vndoeucudh3rfto@piout.net> (raw)
In-Reply-To: <20170828111041.17946-3-afaerber@suse.de>
Hi,
Seems fine to me, one small comment:
On 28/08/2017 at 13:10:40 +0200, Andreas Färber wrote:
> +static int rtd119x_rtc_remove(struct platform_device *pdev)
> +{
> + struct rtd119x_rtc *data = platform_get_drvdata(pdev);
> +
> + rtd119x_rtc_set_enabled(&pdev->dev, false);
> +
> + clk_disable_unprepare(data->clk);
Missing clk_put ?
> +
> + return 0;
> +}
> +
> +static struct platform_driver rtd119x_rtc_driver = {
> + .probe = rtd119x_rtc_probe,
> + .remove = rtd119x_rtc_remove,
> + .driver = {
> + .name = "rtd1295-rtc",
> + .of_match_table = rtd119x_rtc_dt_ids,
> + },
> +};
> +builtin_platform_driver(rtd119x_rtc_driver);
> --
> 2.12.3
>
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-28 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 11:10 [PATCH v3 0/3] arm64: Realtek RTD1295 RTC Andreas Färber
2017-08-28 11:10 ` [PATCH v3 1/3] dt-bindings: rtc: Add Realtek RTD1295 Andreas Färber
2017-08-28 11:10 ` [PATCH v3 2/3] " Andreas Färber
2017-08-28 16:16 ` Alexandre Belloni [this message]
2017-08-28 11:10 ` [PATCH v3 3/3] arm64: dts: realtek: Add RTD1295 RTC node Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828161627.4vndoeucudh3rfto@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=afaerber@suse.de \
--cc=hepeng@zidoo.tv \
--cc=jiang.liqin@geniatech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®