From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751469AbdH1S1i (ORCPT ); Mon, 28 Aug 2017 14:27:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:55802 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751221AbdH1S1h (ORCPT ); Mon, 28 Aug 2017 14:27:37 -0400 Date: Mon, 28 Aug 2017 20:27:23 +0200 From: Borislav Petkov To: Andy Shevchenko Cc: Andy Shevchenko , Tyler Baicar , "Rafael J. Wysocki" , Len Brown , Will Deacon , james.morse@arm.com, shiju.jose@huawei.com, Geliang Tang , Tony Luck , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error Message-ID: <20170828182723.iav5lgucnuhd646f@pd.tnic> References: <1503939221-27732-1-git-send-email-tbaicar@codeaurora.org> <1503939660.25945.127.camel@linux.intel.com> <20170828171405.2s4rlebloi5lyhga@pd.tnic> <20170828172539.5cl7baxdxxaixlri@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 28, 2017 at 08:44:21PM +0300, Andy Shevchenko wrote: > For my opinion, since you asked, the either case needs a comment on > top of that additional check. That's because the comment belongs to the v2 part of the check. > Separate conditionals in independent cases are, of course, better. Yes, and separate are easier to read if you read them like this: + if (rc == -ENOENT) + return rc; <--- Ok, we got the missing entry out of the way, now, here, we have a valid entry. Now we can concentrate on processing it further. ... other check and ack and ... And this becomes a lot more natural when you're staring at a big function which does a lot of things and you concentrate only on the main path. Oh, and this is how those checks get translated to asm as there you don't really have compound if-statements. So if you switch your mind to reading such checks separately, you're practically ready to read their asm translation too... Anyway, this is how I see it. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --