From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751324AbdH2Rts (ORCPT ); Tue, 29 Aug 2017 13:49:48 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36110 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbdH2Rtr (ORCPT ); Tue, 29 Aug 2017 13:49:47 -0400 Date: Tue, 29 Aug 2017 10:49:45 -0700 (PDT) Message-Id: <20170829.104945.1786969849973428586.davem@davemloft.net> To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, samuel@sortiz.org, linux-kernel@vger.kernel.org, fengguang.wu@intel.com, geert@linux-m68k.org Subject: Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel From: David Miller In-Reply-To: <20170829174622.GA25926@kroah.com> References: <20170829172608.GA4700@kroah.com> <20170829173129.GA11029@kroah.com> <20170829174622.GA25926@kroah.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Aug 2017 10:49:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg KH Date: Tue, 29 Aug 2017 19:46:22 +0200 > When moving the IRDA code out of net/ into drivers/staging/irda/net, the > link order changes when IRDA is built into the kernel. That causes a > kernel crash at boot time as netfilter isn't initialized yet. > > To fix this, build and link the irda networking code in the same exact > order that it was previously before the move. > > Reported-by: kernel test robot > Reported-by: Geert Uytterhoeven > Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org Greg, just change the initializer in IRDA so that it will run after subsys_init() when built statically. IRDA is definitely not the first pontentially statically built thing that needs netlink up and available.