mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Stephen Douthit <stephend@adiengineering.com>,
	seth.heasley@intel.com, danp@adiengineering.com,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads
Date: Tue, 29 Aug 2017 07:35:58 -0400	[thread overview]
Message-ID: <20170829113558.GA5406@hmswarspite.think-freely.org> (raw)
In-Reply-To: <20170829102225.7yjh52hivygbdbc7@ninjato>

On Tue, Aug 29, 2017 at 12:22:25PM +0200, Wolfram Sang wrote:
> 
> > >> So basically the byte count already precedes the data in the dma_buffer,
> > >> then the driver sticks desc->rxbytes in front of this resulting in the
> > >> trace above.
> > >>
> > >> The first patch tackles this.
> > >>
> > >> The second patch in the series adds a sanity check on the byte count
> > >> supplied by the slave device.  This might be a nice to have, but is
> > >> probably less critical.
> > > 
> > > Both patches look good to me. Seth, Neil, do you agree?
> > > 
> > 
> > Ping.
> > 
> > Not sure what the usual review time is, let me know if this is premature.
> 
> I applied both patches to for-next (v4.14) now to get a broader
> audience. for-current (v4.13) might have been also applicable, but I
> don't want to apply the patches there without the driver maintainer
> acks. I hope this works for you.
> 

Sorry, I've been on vacation, yes, the patches look good to me

Acked-by: Neil Horman <nhorman@tuxdriver.com>

  reply	other threads:[~2017-08-29 11:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-07 21:10 Stephen Douthit
2017-08-07 21:10 ` [PATCH 1/2] i2c: ismt: Don't duplicate the receive length for " Stephen Douthit
2017-08-07 21:11 ` [PATCH 2/2] i2c: ismt: Return EMSGSIZE for block reads with bogus length Stephen Douthit
2017-08-14 19:31 ` [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads Wolfram Sang
2017-08-28 13:50   ` Stephen Douthit
2017-08-29 10:22     ` Wolfram Sang
2017-08-29 11:35       ` Neil Horman [this message]
2017-08-29 11:49         ` Wolfram Sang
2017-08-29 18:12           ` Dan Priamo
2017-08-29 20:08             ` Wolfram Sang
2017-08-29 20:10               ` Dan Priamo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170829113558.GA5406@hmswarspite.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=danp@adiengineering.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seth.heasley@intel.com \
    --cc=stephend@adiengineering.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®