From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753459AbdH2Lps (ORCPT ); Tue, 29 Aug 2017 07:45:48 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:38725 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbdH2Lpq (ORCPT ); Tue, 29 Aug 2017 07:45:46 -0400 Date: Tue, 29 Aug 2017 13:45:43 +0200 From: Ingo Molnar To: Hannes Reinecke Cc: x86@kernel.org, Boris Petkov , Linux Kernel Mailinglist , Hannes Reinecke Subject: Re: [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST Message-ID: <20170829114543.fftmrkiinhbyemsv@gmail.com> References: <1503913761-60996-1-git-send-email-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503913761-60996-1-git-send-email-hare@suse.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Hannes Reinecke wrote: > When COMPILE_TEST is set we should be compiling 32-bit only > drivers and features (like ISA support etc), too. > After all, it's a compile test. > > Signed-off-by: Hannes Reinecke > --- > arch/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 781521b7cf9e..df61bc37b1a2 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2548,7 +2548,7 @@ config ISA_DMA_API > Enables ISA-style DMA support for devices requiring such controllers. > If unsure, say Y. > > -if X86_32 > +if X86_32 || COMPILE_TEST > > config ISA > bool "ISA support" This is almost certainly a bad idea: if it's a compile test, why not compile test the 32-bit kernel, which will include these drivers? These are drivers that have probably been ever been built in 64-bit mode, and now an allmodconfig/allyesconfig will turn them on... Thanks, Ingo