From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753298AbdH2PcV (ORCPT ); Tue, 29 Aug 2017 11:32:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:46347 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751823AbdH2PcU (ORCPT ); Tue, 29 Aug 2017 11:32:20 -0400 Date: Tue, 29 Aug 2017 17:32:02 +0200 From: Borislav Petkov To: Punit Agrawal Cc: "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-kernel@vger.kernel.org, James Morse Subject: Re: [PATCH v3] ACPI / APEI: Suppress message if HEST not present Message-ID: <20170829150219.4gg3443phihudvbv@pd.tnic> References: <20170829132020.31471-1-punit.agrawal@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170829132020.31471-1-punit.agrawal@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2017 at 02:20:20PM +0100, Punit Agrawal wrote: > According to the ACPI specification, firmware is not required to provide > the Hardware Error Source Table (HEST). When HEST is not present, the > following superfluous message is printed to the kernel boot log - > > [ 3.460067] GHES: HEST is not enabled! > > Extend hest_disable variable to track whether the firmware provides this > table and if it is not present skip any log output. The existing > behaviour is preserved in all other cases. > > Suggested-by: Borislav Petkov > Signed-off-by: Punit Agrawal > Cc: Borislav Petkov > Cc: James Morse > --- > > Changes in v3: > * Grouped hest_disable status checking into a switch/case for clarity > > drivers/acpi/apei/ghes.c | 7 ++++++- > drivers/acpi/apei/hest.c | 13 +++++++------ > include/acpi/apei.h | 8 +++++++- > 3 files changed, 20 insertions(+), 8 deletions(-) Reviewed-by: Borislav Petkov -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --