From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751609AbdH2VEE (ORCPT ); Tue, 29 Aug 2017 17:04:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:57706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbdH2VED (ORCPT ); Tue, 29 Aug 2017 17:04:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F5EC2199E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Tue, 29 Aug 2017 16:04:00 -0500 From: Bjorn Helgaas To: Colin King Cc: Arnd Bergmann , Greg Kroah-Hartman , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: pci_endpoint_test: make boolean no_msi static Message-ID: <20170829210400.GR8154@bhelgaas-glaptop.roam.corp.google.com> References: <20170823094752.26962-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170823094752.26962-1-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 23, 2017 at 10:47:52AM +0100, Colin King wrote: > From: Colin Ian King > > The boolean no_msi is local to the source and does not need to be in > global scope, so make it static. > > Cleans up sparse warning: > symbol 'no_msi' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Folded into the original patch, thanks! > --- > drivers/misc/pci_endpoint_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c > index 1f64d943794d..deb203026496 100644 > --- a/drivers/misc/pci_endpoint_test.c > +++ b/drivers/misc/pci_endpoint_test.c > @@ -73,7 +73,7 @@ static DEFINE_IDA(pci_endpoint_test_ida); > #define to_endpoint_test(priv) container_of((priv), struct pci_endpoint_test, \ > miscdev) > > -bool no_msi; > +static bool no_msi; > module_param(no_msi, bool, 0444); > MODULE_PARM_DESC(no_msi, "Disable MSI interrupt in pci_endpoint_test"); > > -- > 2.14.1 >