From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751390AbdH3HmF (ORCPT ); Wed, 30 Aug 2017 03:42:05 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:59881 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbdH3HmE (ORCPT ); Wed, 30 Aug 2017 03:42:04 -0400 Date: Wed, 30 Aug 2017 09:41:59 +0200 From: Peter Zijlstra To: kernel test robot Cc: LKP , linux-kernel@vger.kernel.org, Ingo Molnar , wfg@linux.intel.com Subject: Re: d82fed7529 ("locking/lockdep/selftests: Fix mixed read-write .."): BUG: -1 unexpected failures (out of 262) - debugging disabled! | Message-ID: <20170830074159.GB660@worktop.programming.kicks-ass.net> References: <59a632f1.24oUFkiRNrafCNaV%fengguang.wu@intel.com> <20170830062947.GJ32112@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170830062947.GJ32112@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 30, 2017 at 08:29:47AM +0200, Peter Zijlstra wrote: > On Wed, Aug 30, 2017 at 11:37:21AM +0800, kernel test robot wrote: > > > [ 0.004000] ----------------------------------------------------------------- > > [ 0.004000] BUG: -1 unexpected failures (out of 262) - debugging disabled! | > > [ 0.004000] ----------------------------------------------------------------- > > lol.. however did that happen.. /me goes look. Ah, I think this should cure.. --- diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c index cd0b5c964bd0..2b827b8a1d8c 100644 --- a/lib/locking-selftest.c +++ b/lib/locking-selftest.c @@ -2031,11 +2031,13 @@ void locking_selftest(void) print_testname("mixed read-lock/lock-write ABBA"); pr_cont(" |"); dotest(rlock_ABBA1, FAILURE, LOCKTYPE_RWLOCK); +#ifdef CONFIG_PROVE_LOCKING /* * Lockdep does indeed fail here, but there's nothing we can do about * that now. Don't kill lockdep for it. */ unexpected_testcase_failures--; +#endif pr_cont(" |"); dotest(rwsem_ABBA1, FAILURE, LOCKTYPE_RWSEM);