From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
airlied@linux.ie, syeh@vmware.com,
linux-graphics-maintainer@vmware.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops
Date: Wed, 30 Aug 2017 10:30:24 +0200 [thread overview]
Message-ID: <20170830083024.fokqszud2euwg476@phenom.ffwll.local> (raw)
In-Reply-To: <5901b4a5-5eef-393f-7d18-704c037708c6@vmware.com>
On Wed, Aug 30, 2017 at 08:21:46AM +0200, Thomas Hellstrom wrote:
> On 08/30/2017 07:47 AM, Arvind Yadav wrote:
> > vmw_fence_ops are not supposed to change at runtime. Functions
> > "dma_fence_init" working with const vmw_fence_ops provided
> > by <linux/dma-fence.h>. So mark the non-const structs as const.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > index b8bc5bc..abc5f03 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > @@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout)
> > return ret;
> > }
> > -static struct dma_fence_ops vmw_fence_ops = {
> > +static const struct dma_fence_ops vmw_fence_ops = {
> > .get_driver_name = vmw_fence_get_driver_name,
> > .get_timeline_name = vmw_fence_get_timeline_name,
> > .enable_signaling = vmw_fence_enable_signaling,
>
> Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Does this mean you'll merge it, or does this mean you'll expect someone
else to merge this?
I'm always confused when maintainers reply with an r-b/ack for a patch
only touching their driver, and no further information at all.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-08-30 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 5:47 Arvind Yadav
2017-08-30 6:21 ` Thomas Hellstrom
2017-08-30 8:30 ` Daniel Vetter [this message]
2017-08-30 9:09 ` Thomas Hellstrom
2017-08-30 15:42 ` Sinclair Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830083024.fokqszud2euwg476@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=arvind.yadav.cs@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syeh@vmware.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®