From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbdH3J6I (ORCPT ); Wed, 30 Aug 2017 05:58:08 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:40058 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbdH3J6H (ORCPT ); Wed, 30 Aug 2017 05:58:07 -0400 Date: Wed, 30 Aug 2017 12:55:47 +0300 From: Dan Carpenter To: Jonathan Whitaker Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, sayli karnik , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: ks7010: Fix coding style and remove checkpatch.pl warnings. Message-ID: <20170830094315.ruzixrf54l3tbhe4@mwanda> References: <1504061856-12258-1-git-send-email-jon.b.whitaker@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504061856-12258-1-git-send-email-jon.b.whitaker@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2017 at 08:57:34PM -0600, Jonathan Whitaker wrote: > It is prefered to use '"%s...", __func__ instead of function names for > logging. This commit replaces hardcoded function name strings to the > more preferred '"%s...", __func__' style. These warnings were reported > by checkpatch.pl. > > Signed-off-by: Jonathan Whitaker > > Changes in v2: > - Wrapped the changelog text to 72 columns. > - Fixed the commit subject to be more clear. > --- Put the Changelog under the --- cut off line. > drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c > index 9b28ee1..c0e91c3 100644 > --- a/drivers/staging/ks7010/ks7010_sdio.c > +++ b/drivers/staging/ks7010/ks7010_sdio.c > @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func, > unsigned char byte; > int ret; > > - DPRINTK(5, "ks7010_sdio_probe()\n"); > + DPRINTK(5, "%s()\n", __func__); Just delete both the printks. You can get the same information with ftrace. regards, dan carpenter