From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399AbdH3ODK (ORCPT ); Wed, 30 Aug 2017 10:03:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:59526 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751317AbdH3ODJ (ORCPT ); Wed, 30 Aug 2017 10:03:09 -0400 Date: Wed, 30 Aug 2017 16:03:05 +0200 From: Jan Kara To: Bhumika Goyal Cc: julia.lawall@lip6.fr, jack@suse.cz, amir73il@gmail.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fsnotify: make dnotify_fsnotify_ops const Message-ID: <20170830140305.GA5462@quack2.suse.cz> References: <1504096742-12621-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504096742-12621-1-git-send-email-bhumirks@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 30-08-17 18:09:02, Bhumika Goyal wrote: > Make this const as it is never modified. > > Signed-off-by: Bhumika Goyal Thanks. Added to my tree. Honza > --- > fs/notify/dnotify/dnotify.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c > index 2430a04..cba3283 100644 > --- a/fs/notify/dnotify/dnotify.c > +++ b/fs/notify/dnotify/dnotify.c > @@ -133,7 +133,7 @@ static void dnotify_free_mark(struct fsnotify_mark *fsn_mark) > kmem_cache_free(dnotify_mark_cache, dn_mark); > } > > -static struct fsnotify_ops dnotify_fsnotify_ops = { > +static const struct fsnotify_ops dnotify_fsnotify_ops = { > .handle_event = dnotify_handle_event, > .free_mark = dnotify_free_mark, > }; > -- > 1.9.1 > -- Jan Kara SUSE Labs, CR