From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432AbdH3OoW (ORCPT ); Wed, 30 Aug 2017 10:44:22 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:44433 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdH3OoV (ORCPT ); Wed, 30 Aug 2017 10:44:21 -0400 Date: Wed, 30 Aug 2017 16:44:09 +0200 From: Maxime Ripard To: Stefan =?iso-8859-1?Q?Br=FCns?= Cc: linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring Subject: Re: [RESEND PATCH 1/2] arm64: allwinner: a64: add SPI nodes Message-ID: <20170830144409.qtewwaffwof34hai@flea.lan> References: <20170829202652.5476-1-stefan.bruens@rwth-aachen.de> <20170829202652.5476-2-stefan.bruens@rwth-aachen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="x23j3wnr72wudkd6" Content-Disposition: inline In-Reply-To: <20170829202652.5476-2-stefan.bruens@rwth-aachen.de> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --x23j3wnr72wudkd6 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Stefan, On Tue, Aug 29, 2017 at 10:26:51PM +0200, Stefan Br=FCns wrote: > The A64 SPI controllers are register compatible to the h3/h5 SPI > controllers. >=20 > The A64 has two SPI controllers, each with a single chip select. > The handles for the DMA channels (23/24 for SPI0/SPI1) are omitted, > as the A64 DMA controller node is currently missing. >=20 > Signed-off-by: Stefan Br=FCns > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 40 +++++++++++++++++++++= ++++++ > 1 file changed, 40 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/b= oot/dts/allwinner/sun50i-a64.dtsi > index bd0f33b77f57..373cd14f0206 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -325,6 +325,16 @@ > drive-strength =3D <40>; > }; > =20 > + spi0_pins: spi0 { > + pins =3D "PC0", "PC1", "PC2", "PC3"; > + function =3D "spi0"; > + }; > + > + spi1_pins: spi1 { > + pins =3D "PD0", "PD1", "PD2", "PD3"; > + function =3D "spi1"; > + }; > + > uart0_pins_a: uart0@0 { > pins =3D "PB8", "PB9"; > function =3D "uart0"; > @@ -527,5 +537,35 @@ > #address-cells =3D <1>; > #size-cells =3D <0>; > }; > + > + spi0: spi@01c68000 { > + compatible =3D "allwinner,sun8i-h3-spi"; > + reg =3D <0x01c68000 0x1000>; > + interrupts =3D ; > + clocks =3D <&ccu CLK_BUS_SPI0>, <&ccu CLK_SPI0>; > + clock-names =3D "ahb", "mod"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&spi0_pins>; > + resets =3D <&ccu RST_BUS_SPI0>; > + status =3D "disabled"; > + num-cs =3D <1>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + }; > + > + spi1: spi@01c69000 { > + compatible =3D "allwinner,sun8i-h3-spi"; > + reg =3D <0x01c69000 0x1000>; > + interrupts =3D ; > + clocks =3D <&ccu CLK_BUS_SPI1>, <&ccu CLK_SPI1>; > + clock-names =3D "ahb", "mod"; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&spi1_pins>; > + resets =3D <&ccu RST_BUS_SPI1>; > + status =3D "disabled"; > + num-cs =3D <1>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + }; Those nodes are ordered by ascending physical base address, so they belong a bit above were you placed them. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --x23j3wnr72wudkd6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZps85AAoJEBx+YmzsjxAgtpQQAIvMHWG/L0QdPERxYgVsFcFX ZjWeus5fMsq4coOQd8ogK5IsvUUxEYve7WnNh1gmz47qiD2KbxfYKIFnPP7nb+eZ MJxpG1vbE76GVn+l2iSQOuiKgCoWVMSwW86dMjKGzraz5f4HC9EZwA/C83vkNhrg ks7IsX/r7MI8w2/cSYqVOQb+Ozp0jRLCXv2/R78QLtRX4RFUGpKZjDONh/ae3t7h BfqhhS5/1Q1+dQEyIlyOOzjnPSXCqddAJWDECRA6CTrjRypIAF/JlS5/GcvC2AsQ SLi+n/0Lq9HVqp04wTzDM1JnISTEYw8VfGK6itnHI/ATC09AprcyJChlKVU6A/sU kfyooRbWQ0JGSERZWK0Iy7TgLqjhRk1v5nL0/c/wCFtsqUPL0N+W+e4th8i8wvdW /ZEvWbVAH86MTouCs17GIbiWJR4Mg3GH6ekbag2e3UkyP3CPiw2cku07e6W/7KIZ z+3Pl/XOAr2XVcoiSHIwZI9tDaECiWVTBBPHQRD4kiNTJIOWRMLZH+tWSYlx16bO FkZvOFckD7rSJnPXQ8n/TcQ29NuuQBk7iOcV05qRwMQTCvHD3lMADkA2zBc2/kOr cnW2rWu/0993inCcKkUUeSvYK/iIrex2Pprv232H61WZHdKyoszpI6nBWbeOCbfC 35K1ESGh9F0oPjD+c6t1 =ONli -----END PGP SIGNATURE----- --x23j3wnr72wudkd6--