From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: andrew@lunn.ch, f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Corentin Labbe <clabbe.montjoie@gmail.com>
Subject: [PATCH 1/5] net: mdio-mux: Fix NULL Comparison style
Date: Wed, 30 Aug 2017 19:46:47 +0200 [thread overview]
Message-ID: <20170830174651.30325-2-clabbe.montjoie@gmail.com> (raw)
In-Reply-To: <20170830174651.30325-1-clabbe.montjoie@gmail.com>
This patch fix checkpatch warning about NULL Comparison style.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/net/phy/mdio-mux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c
index 942ceaf3fd3f..b18ad7082b88 100644
--- a/drivers/net/phy/mdio-mux.c
+++ b/drivers/net/phy/mdio-mux.c
@@ -120,7 +120,7 @@ int mdio_mux_init(struct device *dev,
}
pb = devm_kzalloc(dev, sizeof(*pb), GFP_KERNEL);
- if (pb == NULL) {
+ if (!pb) {
ret_val = -ENOMEM;
goto err_pb_kz;
}
@@ -144,7 +144,7 @@ int mdio_mux_init(struct device *dev,
}
cb = devm_kzalloc(dev, sizeof(*cb), GFP_KERNEL);
- if (cb == NULL) {
+ if (!cb) {
dev_err(dev,
"Error: Failed to allocate memory for child %pOF\n",
child_bus_node);
--
2.13.5
next prev parent reply other threads:[~2017-08-30 17:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 17:46 [PATCH 0/5] net: mdio-mux: Misc fix Corentin Labbe
2017-08-30 17:46 ` Corentin Labbe [this message]
2017-08-30 18:47 ` [PATCH 1/5] net: mdio-mux: Fix NULL Comparison style Andrew Lunn
2017-08-30 17:46 ` [PATCH 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message Corentin Labbe
2017-08-30 18:49 ` Andrew Lunn
2017-08-30 17:46 ` [PATCH 3/5] net: mdio-mux: printing driver version is useless Corentin Labbe
2017-08-30 18:46 ` Andrew Lunn
2017-08-30 17:46 ` [PATCH 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers Corentin Labbe
2017-08-30 18:49 ` Andrew Lunn
2017-08-30 17:46 ` [PATCH 5/5] net: mdio-mux: fix unbalanced put_device Corentin Labbe
2017-08-30 18:53 ` Andrew Lunn
2017-08-30 19:01 ` [PATCH 0/5] net: mdio-mux: Misc fix Andrew Lunn
2017-09-01 8:30 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830174651.30325-2-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®