mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lipeng321@huawei.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxarm@huawei.com, yisen.zhuang@huawei.com,
	salil.mehta@huawei.com
Subject: Re: [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports
Date: Thu, 31 Aug 2017 14:38:27 -0700 (PDT)	[thread overview]
Message-ID: <20170831.143827.1561921608795766649.davem@davemloft.net> (raw)
In-Reply-To: <1504186749-8926-8-git-send-email-lipeng321@huawei.com>

From: Lipeng <lipeng321@huawei.com>
Date: Thu, 31 Aug 2017 21:39:08 +0800

> Config the self_define vlan_type as TPID(0x8100) for vlan identification.
> When normal port initialize vlan configure, set default vlan id as 0.
> 
> Signed-off-by: Mingguang Qu <qumingguang@huawei.com>
> Signed-off-by: Lipeng <lipeng321@huawei.com>

No, that's not what this patch is doing.

> @@ -3308,6 +3308,7 @@ static int hclge_add_mac_vlan_tbl(struct hclge_vport *vport,
>  		mc_desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
>  		hclge_cmd_reuse_desc(&mc_desc[2], false);
>  		mc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_NEXT);
> +
>  		memcpy(mc_desc[0].data, req,
>  		       sizeof(struct hclge_mac_vlan_tbl_entry));
>  		ret = hclge_cmd_send(&hdev->hw, mc_desc, 3);

All it does is add an empty line.

  reply	other threads:[~2017-08-31 21:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31 13:39 [PATCH net-next 0/8] Bug fixes & Code improvements in HNS driver Lipeng
2017-08-31 13:39 ` [PATCH net-next 1/8] net: hns3: add check when initialize Lipeng
2017-08-31 13:39 ` [PATCH net-next 2/8] net: hns3: update ring and vector map command Lipeng
2017-08-31 13:39 ` [PATCH net-next 3/8] net: hns3: set default mac vlan mask Lipeng
2017-08-31 13:39 ` [PATCH net-next 4/8] net: hns3: set default vlan id to PF Lipeng
2017-08-31 13:39 ` [PATCH net-next 5/8] net: hns3: set the VLAN Ethernet type to HW Lipeng
2017-08-31 13:39 ` [PATCH net-next 6/8] net: hns3: fix bug of reuse command description Lipeng
2017-08-31 13:39 ` [PATCH net-next 7/8] net: hns3: add vlan filter config of Ports Lipeng
2017-08-31 21:38   ` David Miller [this message]
2017-08-31 13:39 ` [PATCH net-next 8/8] net: hns3: reimplemmentation of pkt buffer allocation Lipeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170831.143827.1561921608795766649.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=lipeng321@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®