From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbdHaGC6 (ORCPT ); Thu, 31 Aug 2017 02:02:58 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53183 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbdHaGC4 (ORCPT ); Thu, 31 Aug 2017 02:02:56 -0400 X-ME-Sender: X-Sasl-enc: CKUlGZHRrjWE1AfVvlYzIgoc2Ml4QGn5ffywnYm9Dt6i 1504159375 Date: Thu, 31 Aug 2017 08:03:00 +0200 From: Greg KH To: Geert Uytterhoeven Cc: stable , Linux Kernel Mailing List , "ltsi-dev@lists.linuxfoundation.org" , Waiman Long , "Peter Zijlstra (Intel)" , Ingo Molnar Subject: Re: locking/spinlock/debug: Remove spinlock lockup detection code Message-ID: <20170831060300.GB7325@kroah.com> References: <20170220214816.F3A2B66122D@gitolite.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2017 at 03:07:08PM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Mon, Feb 20, 2017 at 10:48 PM, Linux Kernel Mailing List > wrote: > > Web: https://git.kernel.org/torvalds/c/bc88c10d7e6900916f5e1ba3829d66a9de92b633 > > Commit: bc88c10d7e6900916f5e1ba3829d66a9de92b633 > > Parent: f9af456a61ecfbef8233c5046a9e347c9b98ba05 > > Refname: refs/heads/master > > Author: Waiman Long > > AuthorDate: Wed Feb 8 14:46:48 2017 -0500 > > Committer: Ingo Molnar > > CommitDate: Fri Feb 10 09:09:49 2017 +0100 > > > > locking/spinlock/debug: Remove spinlock lockup detection code > > > > The current spinlock lockup detection code can sometimes produce false > > positives because of the unfairness of the locking algorithm itself. > > > > So the lockup detection code is now removed. Instead, we are relying > > on the NMI watchdog to detect potential lockup. We won't have lockup > > detection if the watchdog isn't running. > > > > The commented-out read-write lock lockup detection code are also > > removed. > > > > Signed-off-by: Waiman Long > > Signed-off-by: Peter Zijlstra (Intel) > > Cc: Andrew Morton > > Cc: Linus Torvalds > > Cc: Paul E. McKenney > > Cc: Peter Zijlstra > > Cc: Sasha Levin > > Cc: Thomas Gleixner > > Link: http://lkml.kernel.org/r/1486583208-11038-1-git-send-email-longman@redhat.com > > Signed-off-by: Ingo Molnar > > Can you please backport this commit to v4.9.x and/or ltsi? > > It fixes the following issue in 4.9.40-ltsi on r8a7740/armadillo: > > BUG: spinlock lockup suspected on CPU#0, swapper/1 > lock: lcdc0_device+0xa0/0x258, .magic: 00000000, .owner: > /-1, .owner_cpu: 0 > CPU: 0 PID: 1 Comm: swapper Not tainted > 4.9.40-ltsi-armadillo-00939-gfc8b396897fd0712 #36 > Hardware name: Generic R8A7740 (Flattened Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (do_raw_spin_lock+0xd4/0x118) > [] (do_raw_spin_lock) from [] > (dev_pm_get_subsys_data+0x2c/0x9c) > [] (dev_pm_get_subsys_data) from [] > (genpd_add_device+0x38/0x1b4) > [] (genpd_add_device) from [] > (of_genpd_add_device+0x38/0x50) > [] (of_genpd_add_device) from [] > (board_staging_register_device+0xb0/0xe8) > [] (board_staging_register_device) from [] > (board_staging_register_devices+0x24/0x2c) > [] (board_staging_register_devices) from [] > (runtime_board_check+0x2c/0x40) > [] (runtime_board_check) from [] > (do_one_initcall+0xac/0x154) > [] (do_one_initcall) from [] > (kernel_init_freeable+0x104/0x1c4) > [] (kernel_init_freeable) from [] > (kernel_init+0x8/0x10c) > [] (kernel_init) from [] (ret_from_fork+0x14/0x24) > Now queud up, thanks. greg k-h