From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbdHaNyi (ORCPT ); Thu, 31 Aug 2017 09:54:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:50704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbdHaNyJ (ORCPT ); Thu, 31 Aug 2017 09:54:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 978692199C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 31 Aug 2017 09:54:07 -0400 From: Steven Rostedt To: Zev Weiss Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ftrace: fix debug config symbol in stack_tracer_{en,dis}able Message-ID: <20170831095407.0192c343@gandalf.local.home> In-Reply-To: <20170831070108.24911-1-zev@bewilderbeest.net> References: <20170831070108.24911-1-zev@bewilderbeest.net> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 31 Aug 2017 02:01:08 -0500 Zev Weiss wrote: > Hello, > > It appears stack_tracer_disable()/stack_tracer_enable() have been > using the wrong name for the config symbol to enable their > preempt-debugging checks, which the patch below should fix. (Noticed > when I made the same mistake attempting to grep for > CONFIG_DEBUG_PREEMPT and got two results instead of zero). > > > Zev Weiss Can you resend with a proper change log (no "Hello") and add a Signed-off-by tag? Thanks! -- Steve > > --- > include/linux/ftrace.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index 6383115e9d2c..2e028854bac7 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -307,7 +307,7 @@ DECLARE_PER_CPU(int, disable_stack_tracer); > static inline void stack_tracer_disable(void) > { > /* Preemption or interupts must be disabled */ > - if (IS_ENABLED(CONFIG_PREEMPT_DEBUG)) > + if (IS_ENABLED(CONFIG_DEBUG_PREEMPT)) > WARN_ON_ONCE(!preempt_count() || !irqs_disabled()); > this_cpu_inc(disable_stack_tracer); > } > @@ -320,7 +320,7 @@ static inline void stack_tracer_disable(void) > */ > static inline void stack_tracer_enable(void) > { > - if (IS_ENABLED(CONFIG_PREEMPT_DEBUG)) > + if (IS_ENABLED(CONFIG_DEBUG_PREEMPT)) > WARN_ON_ONCE(!preempt_count() || !irqs_disabled()); > this_cpu_dec(disable_stack_tracer); > }