From: Robert Richter <robert.richter@cavium.com>
To: Zhangshaokun <zhangshaokun@hisilicon.com>
Cc: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com,
catalin.marinas@arm.com, mark.rutland@arm.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, peterz@infradead.org,
mingo@redhat.com, jnair@caviumnetworks.com,
Jonathan.Cameron@huawei.com, gklkml16@gmail.com,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events
Date: Thu, 31 Aug 2017 12:53:17 +0200 [thread overview]
Message-ID: <20170831105317.GQ17961@rric.localdomain> (raw)
In-Reply-To: <b7c40672-8997-c202-7cc2-35b8bc79ecda@hisilicon.com>
Shaokun,
On 31.08.17 18:29:01, Zhangshaokun wrote:
> On 2017/8/29 20:47, Robert Richter wrote:
> > On 29.08.17 17:26:00, Zhangshaokun wrote:
> >> On 2017/8/24 20:03, Ganapatrao Kulkarni wrote:
> >>> This is not a full event list, but a short list of useful events.
> >>>
> >>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> >>> ---
> >>> tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++
> >>> .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++
> >>> 2 files changed, 77 insertions(+)
> >>> create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv
> >>> create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json
> >>>
> >>
> >> I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion
> >> that would use vendor sub-folder?
> >> Of course, appreciate maintainer's comments.
> >
> > this would just add another level of subdirectories. I rather would
> > prefer to have a per platform dir comparable to what is listed in
> >
> > arch/arm64/Kconfig.platforms
> >
>
> Check it again that not all vendors have specific platform config per SoC family,
> so this would not work for us (HiSilicon) and maybe some other vendors.
Even if there is no specific platform defined in Kconfig, you still
could create a platform dir in tools/perf/. There must not be a 1:1
mapping. DT compatible strings may give a hint for naming then.
-Robert
next prev parent reply other threads:[~2017-08-31 10:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 12:03 [PATCH v6 0/4] Add support for ThunderX2 pmu events using json files Ganapatrao Kulkarni
2017-08-24 12:03 ` [PATCH v6 1/4] perf utils: passing pmu as a parameter to function get_cpuid_str Ganapatrao Kulkarni
2017-08-24 12:03 ` [PATCH v6 2/4] perf tools arm64: Add support for get_cpuid_str function Ganapatrao Kulkarni
2017-10-11 12:13 ` Will Deacon
2017-10-12 5:15 ` Ganapatrao Kulkarni
2017-08-24 12:03 ` [PATCH v6 3/4] perf utils: Add helper function is_pmu_core to detect PMU CORE devices Ganapatrao Kulkarni
2017-10-11 12:17 ` Will Deacon
2017-08-24 12:03 ` [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events Ganapatrao Kulkarni
2017-08-29 9:26 ` Zhangshaokun
2017-08-29 12:47 ` Robert Richter
2017-08-30 3:15 ` Zhangshaokun
2017-08-31 10:29 ` Zhangshaokun
2017-08-31 10:53 ` Robert Richter [this message]
2017-10-11 12:19 ` Will Deacon
2017-10-11 13:24 ` Robert Richter
2017-10-11 13:55 ` Will Deacon
2017-10-12 4:56 ` Ganapatrao Kulkarni
2017-09-20 8:45 ` [PATCH v6 0/4] Add support for ThunderX2 pmu events using json files Ganapatrao Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831105317.GQ17961@rric.localdomain \
--to=robert.richter@cavium.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Will.Deacon@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=ganapatrao.kulkarni@cavium.com \
--cc=gklkml16@gmail.com \
--cc=jnair@caviumnetworks.com \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®