From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751363AbdHaMWC (ORCPT <rfc822;w@1wt.eu>);
        Thu, 31 Aug 2017 08:22:02 -0400
Received: from merlin.infradead.org ([205.233.59.134]:39060 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750908AbdHaMWB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 31 Aug 2017 08:22:01 -0400
Date: Thu, 31 Aug 2017 14:21:50 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Martijn Coenen <maco@android.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
        John Stultz <john.stultz@linaro.org>, Todd Kjos <tkjos@google.com>,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Amit Pundir <amit.pundir@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>, Christoph Hellwig <hch@lst.de>,
        LKML <linux-kernel@vger.kernel.org>, devel@driverdev.osuosl.org,
        Martijn Coenen <maco@google.com>, Iliyan Malchev <malchev@google.com>,
        Colin Cross <ccross@android.com>
Subject: Re: [PATCH v2 03/13] ANDROID: binder: add support for RT prio
 inheritance.
Message-ID: <20170831122150.7y2rfvgkppoig5sd@hirez.programming.kicks-ass.net>
References: <20170831080430.118765-1-maco@android.com>
 <20170831080430.118765-4-maco@android.com>
 <20170831081833.q7e7ybcwb2bq2bc5@hirez.programming.kicks-ass.net>
 <CAB0TPYED3thad+GMBYjTGC=gRwjby5MNrGfkeN6qvZtWoaNohw@mail.gmail.com>
 <20170831113221.rvd4eavdm6nqsmpk@hirez.programming.kicks-ass.net>
 <CAB0TPYFuqs36reMTS7FsJg+62Dk7YYuK2b2UzjzpoHx8OfbfqA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAB0TPYFuqs36reMTS7FsJg+62Dk7YYuK2b2UzjzpoHx8OfbfqA@mail.gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 31, 2017 at 02:00:54PM +0200, Martijn Coenen wrote:
> Appreciate if you could take a look! In particular I'm curious why
> this approach is considered "dodgy", or "engineered sideways" as
> Thomas pointed out earlier. 

The fact that you could not reuse rt_mutex makes me very nervous. Other
than that I cannot say anything because I've not actually looked at any
of the code yet.