From: Josef Bacik <josef@toxicpanda.com>
To: Brendan Jackman <brendan.jackman@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Josef Bacik <josef@toxicpanda.com>,
Morten Rasmussen <morten.rasmussen@arm.com>
Subject: Re: [PATCH v3 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest
Date: Thu, 31 Aug 2017 09:54:59 -0400 [thread overview]
Message-ID: <20170831135459.ilgktukuchws2kny@destiny> (raw)
In-Reply-To: <20170831115802.26365-6-brendan.jackman@arm.com>
On Thu, Aug 31, 2017 at 12:58:02PM +0100, Brendan Jackman wrote:
> find_idlest_group returns NULL when the local group is idlest. The
> caller then continues the find_idlest_group search at a lower level
> of the current CPU's sched_domain hierarchy. find_idlest_group_cpu is
> not consulted and, crucially, @new_cpu is not updated. This means the
> search is pointless and we return @prev_cpu from select_task_rq_fair.
>
> This is fixed by initialising @new_cpu to @cpu instead of
> @prev_cpu.
>
Reviewed-by: Josef Bacik <jbacik@fb.com>
Thanks,
Josef
next prev parent reply other threads:[~2017-08-31 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 11:57 [PATCH v3 0/5] sched/fair: Tweaks for select_task_rq_fair slowpath Brendan Jackman
2017-08-31 11:57 ` [PATCH v3 1/5] sched/fair: Move select_task_rq_fair slow-path into its own function Brendan Jackman
2017-08-31 11:57 ` [PATCH v3 2/5] sched/fair: Remove unnecessary comparison with -1 Brendan Jackman
2017-08-31 11:58 ` [PATCH v3 3/5] sched/fair: Fix find_idlest_group when local group is not allowed Brendan Jackman
2017-08-31 13:54 ` Josef Bacik
2017-08-31 11:58 ` [PATCH v3 4/5] sched/fair: Fix use of find_idlest_group when no groups are allowed Brendan Jackman
2017-08-31 13:54 ` Josef Bacik
2017-08-31 11:58 ` [PATCH v3 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest Brendan Jackman
2017-08-31 13:54 ` Josef Bacik [this message]
2017-08-31 16:10 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831135459.ilgktukuchws2kny@destiny \
--to=josef@toxicpanda.com \
--cc=brendan.jackman@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®