From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751988AbdHaRbf (ORCPT ); Thu, 31 Aug 2017 13:31:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37134 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbdHaRbe (ORCPT ); Thu, 31 Aug 2017 13:31:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BD22281DE8 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Thu, 31 Aug 2017 12:31:32 -0500 From: Josh Poimboeuf To: Linus Torvalds Cc: the arch/x86 maintainers , Linux Kernel Mailing List , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andy Lutomirski , Alexander Potapenko , Dmitriy Vyukov , Matthias Kaehlcke , Arnd Bergmann , Peter Zijlstra Subject: Re: [RFC PATCH 3/4] x86/asm: Make alternative macro interfaces more clear and consistent Message-ID: <20170831173132.i5y5p4gdmm4iv3h3@treble> References: <20fac125eed15c916f684e27dfca753d524c6725.1504186968.git.jpoimboe@redhat.com> <20170831172542.k5qchwmgckdcnc6d@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170831172542.k5qchwmgckdcnc6d@treble> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 31 Aug 2017 17:31:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 31, 2017 at 12:25:42PM -0500, Josh Poimboeuf wrote: > 2) Put "sp" in the clobbers list instead of as an i/o constraint. This > mostly works for GCC, and doesn't break clang. However, it causes > GCC to insert a "lea -0x10(%rbp),%rsp" in the epilogue of every > affected function. And maybe this extra instruction is negligible for performance and not a big deal? I might look at this one after the holiday too. -- Josh