From: Jon Mason <jdmason@kudzu.us>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, fancer.lancer@gmail.com,
dave.jiang@intel.com, Allen.Hubbe@emc.com,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NTB: make idt_89hpes_cfg const
Date: Thu, 31 Aug 2017 13:55:56 -0400 [thread overview]
Message-ID: <20170831175555.GB28190@kudzu.us> (raw)
In-Reply-To: <1502473663-6136-1-git-send-email-bhumirks@gmail.com>
On Fri, Aug 11, 2017 at 11:17:43PM +0530, Bhumika Goyal wrote:
> Make these const as they are only used during a copy operation.
> Done using Coccinelle.
Pulled into my ntb-next branch
Thanks,
Jon
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/ntb/hw/idt/ntb_hw_idt.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
> index d44d7ef..0cd79f3 100644
> --- a/drivers/ntb/hw/idt/ntb_hw_idt.c
> +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
> @@ -2628,35 +2628,35 @@ static void idt_pci_remove(struct pci_dev *pdev)
> /*
> * IDT PCIe-switch models ports configuration structures
> */
> -static struct idt_89hpes_cfg idt_89hpes24nt6ag2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes24nt6ag2_config = {
> .name = "89HPES24NT6AG2",
> .port_cnt = 6, .ports = {0, 2, 4, 6, 8, 12}
> };
> -static struct idt_89hpes_cfg idt_89hpes32nt8ag2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes32nt8ag2_config = {
> .name = "89HPES32NT8AG2",
> .port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
> };
> -static struct idt_89hpes_cfg idt_89hpes32nt8bg2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes32nt8bg2_config = {
> .name = "89HPES32NT8BG2",
> .port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
> };
> -static struct idt_89hpes_cfg idt_89hpes12nt12g2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes12nt12g2_config = {
> .name = "89HPES12NT12G2",
> .port_cnt = 3, .ports = {0, 8, 16}
> };
> -static struct idt_89hpes_cfg idt_89hpes16nt16g2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes16nt16g2_config = {
> .name = "89HPES16NT16G2",
> .port_cnt = 4, .ports = {0, 8, 12, 16}
> };
> -static struct idt_89hpes_cfg idt_89hpes24nt24g2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes24nt24g2_config = {
> .name = "89HPES24NT24G2",
> .port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
> };
> -static struct idt_89hpes_cfg idt_89hpes32nt24ag2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes32nt24ag2_config = {
> .name = "89HPES32NT24AG2",
> .port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
> };
> -static struct idt_89hpes_cfg idt_89hpes32nt24bg2_config = {
> +static const struct idt_89hpes_cfg idt_89hpes32nt24bg2_config = {
> .name = "89HPES32NT24BG2",
> .port_cnt = 8, .ports = {0, 2, 4, 6, 8, 12, 16, 20}
> };
> --
> 1.9.1
>
prev parent reply other threads:[~2017-08-31 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 17:47 Bhumika Goyal
2017-08-31 17:55 ` Jon Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831175555.GB28190@kudzu.us \
--to=jdmason@kudzu.us \
--cc=Allen.Hubbe@emc.com \
--cc=bhumirks@gmail.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®