mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Meyer <thomas@m3y3r.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] vt: Use bsearch library function in is_double_width
Date: Fri, 1 Sep 2017 01:26:24 +0200	[thread overview]
Message-ID: <20170831232517.nquvomamw4fp5dq4@olymp> (raw)
In-Reply-To: <20170831150253.GB15886@kroah.com>

On Thu, Aug 31, 2017 at 05:02:53PM +0200, Greg KH wrote:
> On Thu, Aug 31, 2017 at 04:21:15PM +0200, Thomas Meyer wrote:
> > Use bsearch library function instead of duplicated functionality.
> > 
One question: Having above changelog text and a nearly similar subject line is
fine for you?

> > v2: Re-introduce early exit from old binary search.
> 
> That's not the difference from the previous patch...

It isn't?

v2 adds those lines:
+      if (ucs < double_width[0].first ||
+          ucs > double_width[ARRAY_SIZE(double_width) - 1].last)
+              return 0;

Which is the early exit from the old binary search, i.e. the current
implementation
What do you mean with "that's not the difference from the previous
patch"?

> 
> And that info goes below the --- line, as the documentation states.

So besides adding v2 comment below the --- line, what else do you want
me to change to accept this patch?

      reply	other threads:[~2017-08-31 23:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31 13:04 [PATCH] " Thomas Meyer
2017-08-31 13:34 ` Greg KH
2017-08-31 14:20 ` [PATCH v2] ipv6: sr: Use ARRAY_SIZE macro Thomas Meyer
2017-08-31 15:02   ` Greg KH
2017-08-31 23:15     ` Thomas Meyer
2017-08-31 14:21 ` [PATCH v2] vt: Use bsearch library function in is_double_width Thomas Meyer
2017-08-31 15:02   ` Greg KH
2017-08-31 23:26     ` Thomas Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170831232517.nquvomamw4fp5dq4@olymp \
    --to=thomas@m3y3r.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®