From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbdIAJso (ORCPT ); Fri, 1 Sep 2017 05:48:44 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:35925 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbdIAJsm (ORCPT ); Fri, 1 Sep 2017 05:48:42 -0400 Date: Fri, 1 Sep 2017 11:48:32 +0200 From: Peter Zijlstra To: Kees Cook Cc: Elena Reshetova , Andrew Morton , LKML , "linux-fsdevel@vger.kernel.org" , Greg KH , Al Viro , Tejun Heo , Ingo Molnar , Johannes Weiner , Li Zefan , Arnaldo Carvalho de Melo , Alexander Shishkin , Eric Paris , Arnd Bergmann , Andy Lutomirski , Thomas Gleixner , dvhart@infradead.org, "Eric W. Biederman" Subject: Re: [PATCH 00/15] v5 kernel core pieces refcount conversions Message-ID: <20170901094832.inwuzxczxs4b2ehh@hirez.programming.kicks-ass.net> References: <1504095773-22895-1-git-send-email-elena.reshetova@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 31, 2017 at 04:48:00PM -0700, Kees Cook wrote: > On Wed, Aug 30, 2017 at 5:22 AM, Elena Reshetova > wrote: > > Now we have at least x86 support for ARCH_HAS_REFCOUNT merged and > > arm and others on their way. > > > > Changes in v5: > > * Kees catched that the following changes in > > perf_event_context.refcount and futex_pi_state.refcount > > are not correct now when ARCH_HAS_REFCOUNT is enabled: > > - WARN_ON(!atomic_inc_not_zero(refcount)); > > + refcount_inc(refcount); > > So they are now changed back to using refcount_inc_not_zero. > > Thanks! > > Reviewed-by: Kees Cook > > Andrew, are you able to carry these patches in -mm, since they span a > bunch of core kernel areas? No.. these patches should go through the regular trees that maintain these various parts.