From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: andrew@lunn.ch, f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Corentin Labbe <clabbe.montjoie@gmail.com>
Subject: [PATCH v2 3/5] net: mdio-mux: printing driver version is useless
Date: Fri, 1 Sep 2017 13:56:02 +0200 [thread overview]
Message-ID: <20170901115604.27513-4-clabbe.montjoie@gmail.com> (raw)
In-Reply-To: <20170901115604.27513-1-clabbe.montjoie@gmail.com>
Remove the driver version information because this information
is not useful in an upstream kernel driver.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/net/phy/mdio-mux.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c
index 5e08e89465c5..282828551bdd 100644
--- a/drivers/net/phy/mdio-mux.c
+++ b/drivers/net/phy/mdio-mux.c
@@ -13,7 +13,6 @@
#include <linux/module.h>
#include <linux/phy.h>
-#define DRV_VERSION "1.0"
#define DRV_DESCRIPTION "MDIO bus multiplexer driver"
struct mdio_mux_child_bus;
@@ -179,7 +178,6 @@ int mdio_mux_init(struct device *dev,
}
if (pb->children) {
*mux_handle = pb;
- dev_info(dev, "Version " DRV_VERSION "\n");
return 0;
}
@@ -212,6 +210,5 @@ void mdio_mux_uninit(void *mux_handle)
EXPORT_SYMBOL_GPL(mdio_mux_uninit);
MODULE_DESCRIPTION(DRV_DESCRIPTION);
-MODULE_VERSION(DRV_VERSION);
MODULE_AUTHOR("David Daney");
MODULE_LICENSE("GPL");
--
2.13.5
next prev parent reply other threads:[~2017-09-01 11:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 11:55 [PATCH v2 0/5] net: mdio-mux: Misc fix Corentin Labbe
2017-09-01 11:56 ` [PATCH v2 1/5] net: mdio-mux: Fix NULL Comparison style Corentin Labbe
2017-09-01 11:56 ` [PATCH v2 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message Corentin Labbe
2017-09-01 11:56 ` Corentin Labbe [this message]
2017-09-01 13:38 ` [PATCH v2 3/5] net: mdio-mux: printing driver version is useless Andrew Lunn
2017-09-01 11:56 ` [PATCH v2 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers Corentin Labbe
2017-09-01 11:56 ` [PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device Corentin Labbe
2017-09-01 13:38 ` Andrew Lunn
2017-09-01 17:26 ` [PATCH v2 0/5] net: mdio-mux: Misc fix David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901115604.27513-4-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®