From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752110AbdIAOU2 (ORCPT ); Fri, 1 Sep 2017 10:20:28 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34552 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbdIAOU0 (ORCPT ); Fri, 1 Sep 2017 10:20:26 -0400 X-Google-Smtp-Source: ADKCNb7B4jTFbKxaSGpns7l9dAufSbhbRO5aRJdZTQ4vOazF0TAMpm3qq+aFf50CkMDnIYTI5EsdRg== Date: Fri, 1 Sep 2017 07:20:24 -0700 From: Guenter Roeck To: Colin King Cc: Greg Kroah-Hartman , Hans de Goede , Yueyao Zhu , Rui Miguel Silva , Guru Das Srinagesh , Frans Klaver , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][staging-next] staging: typec: fusb302: make structure fusb302_psy_desc static Message-ID: <20170901142023.GA599@roeck-us.net> References: <20170901102057.17637-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170901102057.17637-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 01, 2017 at 11:20:57AM +0100, Colin King wrote: > From: Colin Ian King > > The const structure fusb302_psy_desc is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warnings > symbol 'fusb302_psy_desc' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/fusb302/fusb302.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c > index cf6355f59cd9..fc6a3cf74eb3 100644 > --- a/drivers/staging/typec/fusb302/fusb302.c > +++ b/drivers/staging/typec/fusb302/fusb302.c > @@ -1723,7 +1723,7 @@ static enum power_supply_property fusb302_psy_properties[] = { > POWER_SUPPLY_PROP_CURRENT_MAX, > }; > > -const struct power_supply_desc fusb302_psy_desc = { > +static const struct power_supply_desc fusb302_psy_desc = { > .name = "fusb302-typec-source", > .type = POWER_SUPPLY_TYPE_USB_TYPE_C, > .properties = fusb302_psy_properties, > -- > 2.14.1 >