From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
kasan-dev@googlegroups.com
Subject: kmemleak not always catching stuff
Date: Fri, 1 Sep 2017 18:33:11 -0400 [thread overview]
Message-ID: <20170901183311.3bf3348a@gandalf.local.home> (raw)
Hi,
Recently kmemleak discovered a bug in my code where an allocated
trampoline for a ftrace function tracer wasn't freed due to an exit
path. The thing is, kmemleak was able to catch this 100% when it was
triggered by one of my ftrace selftests that happen at bootup. But when
I trigger the issue from user space after bootup finished, it would not
catch it.
Now I was thinking that it may be due to the fact that the trampoline
is allocated with module_alloc(), and that has some magic kasan goo in
it. But when forcing the issue with adding the following code:
void **pblah;
void *blah;
pblah = kmalloc(sizeof(*pblah), GFP_KERNEL);
blah = module_alloc(PAGE_SIZE);
*pblah = blah;
printk("allocated blah %p\n", blah);
kfree(pblah);
in a path that I could control, it would catch it only after doing it
several times. I was never able to have kmemleak catch the actual bug
from user space no matter how many times I triggered it.
# dmesg |grep kmemleak
[ 16.746832] kmemleak: Kernel memory leak detector initialized
[ 16.746888] kmemleak: Automatic memory scanning thread started
And then I would do:
# echo scan=on > /sys/kernel/debug/kmemleak
[do the test]
# echo scan > /sys/kernel/debug/kmemleak
Most of the times it found nothing. Even when I switched the above from
module_alloc() to kmalloc().
Is this normal?
-- Steve
next reply other threads:[~2017-09-01 22:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 22:33 Steven Rostedt [this message]
2017-09-02 10:35 ` Dmitry Vyukov
2017-09-04 10:09 ` Catalin Marinas
2017-09-05 14:15 ` Steven Rostedt
2017-09-08 17:45 ` Catalin Marinas
2017-09-08 18:34 ` Steven Rostedt
2017-09-05 14:23 ` Dmitry Vyukov
2017-09-05 14:39 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901183311.3bf3348a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®