From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbdIAVbZ (ORCPT ); Fri, 1 Sep 2017 17:31:25 -0400 Received: from a2nlsmtp01-04.prod.iad2.secureserver.net ([198.71.225.38]:51780 "EHLO a2nlsmtp01-04.prod.iad2.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbdIAVbU (ORCPT ); Fri, 1 Sep 2017 17:31:20 -0400 x-originating-ip: 107.180.71.197 From: Haiyang Zhang To: davem@davemloft.net, netdev@vger.kernel.org Cc: haiyangz@microsoft.com, kys@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, linux-kernel@vger.kernel.org Subject: [PATCH net-next, 2/4] hv_netvsc: Simplify num_chn checking in rndis_filter_device_add() Date: Fri, 1 Sep 2017 14:30:05 -0700 Message-Id: <20170901213007.10325-3-haiyangz@exchange.microsoft.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170901213007.10325-1-haiyangz@exchange.microsoft.com> References: <20170901213007.10325-1-haiyangz@exchange.microsoft.com> Reply-To: haiyangz@microsoft.com X-CMAE-Envelope: MS4wfFsqBTE4BVzatd04QQKER4bLMNRs/uUEH5gAFnlu9y0rYduzxPL4hLNhneEQdkTcJWnZ19YAVFo3TcHxOdsqUFW23Y9527zzPYdvwWzYVZrmyf/e1Wx9 15Eo04sSQEKn7RohEIaIwkSieRmAIm2hK5kH4ItoCQBRMjT4KT0viYcCeCqQMm5TK8dfB6EWAjD8TkDZOgAlIjNTT6YPNHHY+KWVCOgp9yIg/EWgeGwc/Qpp GDYnoKcTHaD7ERNZ5edHEa45NV2CupRfN+TsiHqVPedrfLrzE61nIx3zjGTt8ZJsyeQQ6jlRMuZYJ/2R1wqnZ/nzyiF34QWWM96c2LoKvy3r+taBZ9yIzKDK hmccHyXu6qrAywRhdJ7ZoKzFYiHCrg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang The minus one and assignment to a local variable is not necessary. This patch simplifies it. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/rndis_filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 496fefa7c7c4..69c40b8fccc3 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -1067,7 +1067,7 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev, struct ndis_recv_scale_cap rsscap; u32 rsscap_size = sizeof(struct ndis_recv_scale_cap); unsigned int gso_max_size = GSO_MAX_SIZE; - u32 mtu, size, num_rss_qs; + u32 mtu, size; const struct cpumask *node_cpu_mask; u32 num_possible_rss_qs; int i, ret; @@ -1215,8 +1215,8 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev, net_device->num_chn); atomic_set(&net_device->open_chn, 1); - num_rss_qs = net_device->num_chn - 1; - if (num_rss_qs == 0) + + if (net_device->num_chn == 1) return net_device; for (i = 1; i < net_device->num_chn; i++) { -- 2.14.1