From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751011AbdIBBF0 (ORCPT ); Fri, 1 Sep 2017 21:05:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:47290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbdIBBFZ (ORCPT ); Fri, 1 Sep 2017 21:05:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 116A021B7E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jaegeuk@kernel.org Date: Fri, 1 Sep 2017 18:05:24 -0700 From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH] f2fs: avoid needless inode updates Message-ID: <20170902010524.GA23704@jaegeuk-macbookpro.roam.corp.google.com> References: <20170902000516.21080-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170902000516.21080-1-jaegeuk@kernel.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please ignore this patch. Thanks, On 09/01, Jaegeuk Kim wrote: > If i_size wan't change at all, we don't need to write inode during fsync. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/f2fs.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 4b993961d81d..0d76b572484a 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -2267,11 +2267,11 @@ static inline bool f2fs_skip_inode_update(struct inode *inode, int dsync) > spin_unlock(&sbi->inode_lock[DIRTY_META]); > return ret; > } > - if (!is_inode_flag_set(inode, FI_AUTO_RECOVER) || > - file_keep_isize(inode) || > - i_size_read(inode) & PAGE_MASK) > - return false; > - return F2FS_I(inode)->last_disk_size == i_size_read(inode); > + if (F2FS_I(inode)->last_disk_size == i_size_read(inode)) > + return true; > + > + return is_inode_flag_set(inode, FI_AUTO_RECOVER) && > + !file_keep_isize(inode) && !(i_size_read(inode) & PAGE_MASK); > } > > static inline int f2fs_readonly(struct super_block *sb) > -- > 2.14.0.rc1.383.gd1ce394fe2-goog