From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752513AbdIBKc0 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 2 Sep 2017 06:32:26 -0400
Received: from mail-wr0-f195.google.com ([209.85.128.195]:35845 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751366AbdIBKcY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 2 Sep 2017 06:32:24 -0400
X-Google-Smtp-Source: ADKCNb6Pk/J5mmA11zRX/RYLUN5edTD3EFA/+aeeWYRXmKrkOJlo/QL0ZUzNQ6KETIi+AlkHPcD+ww==
Date: Sat, 2 Sep 2017 12:32:21 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Alexander Potapenko <glider@google.com>,
        Dmitriy Vyukov <dvyukov@google.com>,
        Matthias Kaehlcke <mka@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC PATCH 3/4] x86/asm: Make alternative macro interfaces more
 clear and consistent
Message-ID: <20170902103221.5gw5vtxxknprzgdr@gmail.com>
References: <cover.1504186968.git.jpoimboe@redhat.com>
 <20fac125eed15c916f684e27dfca753d524c6725.1504186968.git.jpoimboe@redhat.com>
 <CA+55aFzuEvwLH9oi-vX4oMM5udLtDVH6jfA7LzptAcoFVE8fiQ@mail.gmail.com>
 <20170831172542.k5qchwmgckdcnc6d@treble>
 <20170831173132.i5y5p4gdmm4iv3h3@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170831173132.i5y5p4gdmm4iv3h3@treble>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Thu, Aug 31, 2017 at 12:25:42PM -0500, Josh Poimboeuf wrote:
> > 2) Put "sp" in the clobbers list instead of as an i/o constraint.  This
> >    mostly works for GCC, and doesn't break clang.  However, it causes
> >    GCC to insert a "lea -0x10(%rbp),%rsp" in the epilogue of every
> >    affected function.
> 
> And maybe this extra instruction is negligible for performance and not a
> big deal?  I might look at this one after the holiday too.

Please do statistics of how many functions are affected, on a defconfig-ish 
kernel.

Thanks,

	Ingo