From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753908AbdIDOYZ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Sep 2017 10:24:25 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:45984 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753687AbdIDOYY (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Sep 2017 10:24:24 -0400
Date: Mon, 4 Sep 2017 16:24:19 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Mike Galbraith <efault@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Byungchul Park <max.byungchul.park@gmail.com>
Subject: Re: hotplug lockdep splat (tip)
Message-ID: <20170904142419.6dfbwx5eedkykpeo@hirez.programming.kicks-ass.net>
References: <1504350596.16793.44.camel@gmx.de>
 <1504421975.30792.32.camel@gmx.de>
 <20170904075502.74pgfd2twdfklspw@hirez.programming.kicks-ass.net>
 <1504531627.10288.5.camel@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1504531627.10288.5.camel@gmx.de>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 04, 2017 at 03:27:07PM +0200, Mike Galbraith wrote:
> On Mon, 2017-09-04 at 09:55 +0200, Peter Zijlstra wrote:
> > On Sun, Sep 03, 2017 at 08:59:35AM +0200, Mike Galbraith wrote:
> > > 
> > > [  126.626908] Unregister pv shared memory for cpu 1
> > > [  126.631041] 
> > > [  126.631269] ======================================================
> > > [  126.632442] WARNING: possible circular locking dependency detected
> > > [  126.633599] 4.13.0.g06260ca-tip-lockdep #2 Tainted: G            E  
> > > [  126.634380] ------------------------------------------------------
> > > [  126.635124] stress-cpu-hotp/3156 is trying to acquire lock:
> > > [  126.635804]  ((complete)&st->done){+.+.}, at: [<ffffffff8108d19a>] takedown_cpu+0x8a/0xf0
> > > [  126.636809] 
> > > [  126.636809] but task is already holding lock:
> > > [  126.637567]  (sparse_irq_lock){+.+.}, at: [<ffffffff81107ac7>] irq_lock_sparse+0x17/0x20
> > > [  126.638665] 
> > 
> > https://lkml.kernel.org/r/20170829193416.GC32112@worktop.programming.kicks-ass.net
> 
> Well, flavor of gripe changed.
> 
> [  164.114290] ======================================================
> [  164.115146] WARNING: possible circular locking dependency detected
> [  164.115751] 4.13.0.g90abd70-tip-lockdep #4 Tainted: G            E  
> [  164.116348] ------------------------------------------------------
> [  164.116919] cpuhp/0/12 is trying to acquire lock:
> [  164.117381]  (cpuhp_state){+.+.}, at: [<ffffffff8108e4aa>] cpuhp_thread_fun+0x2a/0x160
> [  164.118097] 
>                but now in release context of a crosslock acquired at the following:
> [  164.118845]  ((complete)&per_cpu_ptr(&cpuhp_state, i)->done#2){+.+.}, at: [<ffffffff8108e71f>] cpuhp_issue_call+0x13f/0x170
> [  164.119789] 

Cute, I'd not seen that one.. anything special required to reproduce?