From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753905AbdIDQvK (ORCPT ); Mon, 4 Sep 2017 12:51:10 -0400 Received: from one.firstfloor.org ([193.170.194.197]:60912 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753847AbdIDQvI (ORCPT ); Mon, 4 Sep 2017 12:51:08 -0400 Date: Mon, 4 Sep 2017 09:51:06 -0700 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Sukadev Bhattiprolu , Andi Kleen , Anton Blanchard , Jiri Olsa , Michael Ellerman , Arnaldo Carvalho de Melo Subject: Re: [PATCH 06/13] perf vendor events powerpc: Remove duplicate events Message-ID: <20170904165106.GT2482@two.firstfloor.org> References: <20170904140044.22912-1-acme@kernel.org> <20170904140044.22912-7-acme@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170904140044.22912-7-acme@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 04, 2017 at 11:00:37AM -0300, Arnaldo Carvalho de Melo wrote: > From: Sukadev Bhattiprolu > > Some POWER PMU event names have multiple/alternate event codes. These > alternate event codes were listed in the POWER9 JSON files for > reference. > > But the perf tool does not seem to handle duplicates cleanly. 'perf > list' shows such duplicate events only once, but 'perf stat' ends up > counting the first event code twice, multiplexing if necessary and we > end up with double the event counts. > > Remove the duplicate event codes from the JSON files for now. It would be better to fix it in perf. I assume it wouldn't be that hard. Intel may get multiple versions of events at some point too, as events get renamed, but the old names stay around for compatibility. -Andi