From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbdIEQMs (ORCPT ); Tue, 5 Sep 2017 12:12:48 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34352 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbdIEQMo (ORCPT ); Tue, 5 Sep 2017 12:12:44 -0400 Date: Tue, 05 Sep 2017 09:12:43 -0700 (PDT) Message-Id: <20170905.091243.2291345820364652641.davem@davemloft.net> To: arnd@arndb.de Cc: gwshan@linux.vnet.ibm.com, sam@mendozajonas.com, joel@jms.id.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/ncsi: fix ncsi_vlan_rx_{add,kill}_vid references From: David Miller In-Reply-To: <20170905080615.1131665-1-arnd@arndb.de> References: <20170905080615.1131665-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Sep 2017 09:12:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 5 Sep 2017 10:05:47 +0200 > We get a new link error in allmodconfig kernels after ftgmac100 > started using the ncsi helpers: > > ERROR: "ncsi_vlan_rx_kill_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined! > ERROR: "ncsi_vlan_rx_add_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined! > > Related to that, we get another error when CONFIG_NET_NCSI is disabled: > > drivers/net/ethernet/faraday/ftgmac100.c:1626:25: error: 'ncsi_vlan_rx_add_vid' undeclared here (not in a function); did you mean 'ncsi_start_dev'? > drivers/net/ethernet/faraday/ftgmac100.c:1627:26: error: 'ncsi_vlan_rx_kill_vid' undeclared here (not in a function); did you mean 'ncsi_vlan_rx_add_vid'? > > This fixes both problems at once, using a 'static inline' stub helper > for the disabled case, and exporting the functions when they are present. > > Fixes: 51564585d8c6 ("ftgmac100: Support NCSI VLAN filtering when available") > Fixes: 21acf63013ed ("net/ncsi: Configure VLAN tag filter") > Signed-off-by: Arnd Bergmann Applied.