From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752306AbdIEHOL (ORCPT ); Tue, 5 Sep 2017 03:14:11 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:49994 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbdIEHOG (ORCPT ); Tue, 5 Sep 2017 03:14:06 -0400 From: Arnd Bergmann To: Mauro Carvalho Chehab , Richard Purdie , Jacek Anaszewski , Pavel Machek Cc: Sakari Ailus , Arnd Bergmann , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency Date: Tue, 5 Sep 2017 09:13:20 +0200 Message-Id: <20170905071345.3807685-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:/7vs0pf0Loq+1SDZd8jFG256kB8UZSnK1bE3QYf6bODyqW+rRBM trgxm7dUqUZKB0psyu7VAEqd+XLPeLtuUsVzz5qWpai0p7NqBiTXccwnU0Zp93nZhPb0WN5 TiYNBaSidxw9p7STgM2tUFu31TJC2RUYg2/iPvyL5ruAOpOaOlRkh0+A82vQCo8YOb/qZis VBBh/1OjJgeSctTAAmQpg== X-UI-Out-Filterresults: notjunk:1;V01:K0:7LWTkpOcmNc=:YpsaJOowyyXPKA4MbiYNVV kAddcrUIU3Fb175i59EOHjT8L7Rq2VL4VJpxUfBgRL4q8Mudi9+lIrvhDFSS3rf5UF1rd1QtL FFNkVvNvgpugEFyKpuITTfpK/zZcDxtyMltZCcdtJlvpxsS9OOT+mGj4oKDvnRPRdvKxIHgTx d8EqW5Aa37s+0eWBy999XcnK+nq6alPSwpkSvKjIDLeL0Tw/y44d2Y1cYeYSvRtUgSm+63Lf4 BPHEDrKC+/NJ96Eb6PkM0Ov7bN3Qhmd+6GrIfRqnj5FSScs2nGHEGLeLipUYbHWcnYmiYFwt4 WdTbJzr2ckR2gpZqs6e/hdKV3qJRJtq15uichsAXcVYbxflOczG4YNLA+OFr7VF34zKUQ1MNB rqZEbSK4CkAyDrb948DMjlRMWeh0zGtQ4Zaw3bOUbMd7a8FRTbZQJ1KSTOG4w++oFbPTxsu+3 5dyxteyzWCAdUzpotxrri01pNet6tGazoLrK/p2ScuF9zG4XPbMK4VER1pjs4x1Mae50cWFfC 2jQ6nezEFhd2kxcDlfA1Fn3EDMvBHgmzWx2zIZIt3TwoC8rRVaHc9YjlBGMUe/GOsE3CunIn0 UnvEbXpqM4deLDGnR8yGWXpe1f234HJpQDiCtjevkTL1m5Ev5JE68w8YizmnoBZY3wHQVNTWm EvjFFSQQDjc9ugW6HA+gsxIk/LpnfgzeVCevDgrFz4rJFOxtiHH9MuFwDFSmoQef2a00ZuJc8 uPfNSPilOx8aqP+1d6DImH38uH6BF+RUWu1LTA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We get a link error when V4L2_FLASH_LED_CLASS=m and AS3645A is built-in: drivers/leds/leds-as3645a.o: In function `as3645a_v4l2_setup': leds-as3645a.c:(.text+0x258): undefined reference to `v4l2_flash_init' leds-as3645a.c:(.text+0x284): undefined reference to `v4l2_flash_indicator_init' leds-as3645a.c:(.text+0x2a4): undefined reference to `v4l2_flash_release' drivers/leds/leds-as3645a.o: In function `as3645a_remove': leds-as3645a.c:(.text+0x784): undefined reference to `v4l2_flash_release' This adds the same Kconfig dependency that the other V4L2 flash drivers in drivers/leds use, to avoid that broken configuration. Fixes: a56ba8fbcb55 ("media: leds: as3645a: Add LED flash class driver") Signed-off-by: Arnd Bergmann --- drivers/leds/Kconfig | 1 + 1 file changed, 1 insertion(+) The patch that caused the problem is currently in the v4l git tree, rather than the leds tree. Please merge this through an appropriate path, either v4l or led, depending on the timing. diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 0bf022bcb6ac..52ea34e337cd 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -61,6 +61,7 @@ config LEDS_AAT1290 config LEDS_AS3645A tristate "AS3645A LED flash controller support" depends on I2C && LEDS_CLASS_FLASH + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS help Enable LED flash class support for AS3645A LED flash controller. V4L2 flash API is provided as well if -- 2.9.0